517746 - Fix XHTML validation errors on the Community, Foundation, and Projects sections

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Roland Warmerdam]

Attachment: Fixes HTML errors on the Community and Projects sections

This patch fixes most of the HTML validation errors on the Community and Projects sections of the site.

Comment 1

[Roland Warmerdam]

Attachment: Updated the patch and excluded generated pages

Comment 2

[David Boswell]

Roland, thanks for making those tweaks to the patch.  I just reviewed this and have a few comments:

* I'd include community/gen-ng-info as part of the patch for changes generated pages.  The person who owns that is different than from the straight HTML files.

* Should we be changing '&' signs in URLs to '&'?  I spotted checked some of these and some worked fine, but one returned different pages.  Compare:

http://www.google.com/search?q=Mozilla&ie=UTF-8&oe=UTF-8&hl=zh-TW&lr=lang_zh-TW
http://www.google.com/search?q=Mozilla&ie=UTF-8&oe=UTF-8&hl=zh-TW&lr=lang_zh-TW

* In the projects/powered-by.html page there's a space in the link to <a href="/about/manifesto "> that I suppose we should remove.

Comment 3

[Roland Warmerdam]

My bad, I forgot to exclude the gen-ng-info file from the patch. And yes, we should be changing '&' signs to '&' because otherwise the xml parser tries to read & and the characters following as html entities.

I'll submit a fixed version of the patch later today.

Comment 4

[David Boswell]

If changing the & signs in URLs changes where those links go, perhaps we need to allow those pages to not validate?

Comment 5

[Reed Loden [:reed]]

Comment on attachment 402561 [details] [diff] [review]
Updated the patch and excluded generated pages

>+<p><span style="text-decoration:underline">Best Viewed With Buttons</span>.  
>+<p><span style="text-decoration:underline">Site Icons (favicons)</span>. If you 
>+<p><span style="text-decoration:underline">High Resolution Copies</span>.  We 

Is there some CSS class we can use instead of something like this? If not, I prefer the form |style="text-decoration: underline;"|.

r=me with that.

Comment 6

[Reed Loden [:reed]]

(In reply to comment #4)
> If changing the & signs in URLs changes where those links go, perhaps we need
> to allow those pages to not validate?

No, he's changing them so that they will be correct.

Comment 7

[David Boswell]

Did you try out the two links mentioned in comment #2?  The existing link from community/intl/zh.html goes to a Google results page localized in zh-TW.  The one from the patch goes to a search result in English.  

Google doesn't seem to be processing the &amp part of the URL the same way as the &.  In fact, it seems to be ignoring everything after the first & since the results page looks like same as:

http://www.google.com/search?q=Mozilla

Comment 8

[Reed Loden [:reed]]

(In reply to comment #7)
> Did you try out the two links mentioned in comment #2?  The existing link from
> community/intl/zh.html goes to a Google results page localized in zh-TW.  The
> one from the patch goes to a search result in English.

Take a look at the source code for that comment on this bug:
=============================
* Should we be changing '&' signs in URLs to '&'?  I spotted checked some
of these and some worked fine, but one returned different pages.  Compare:

<a href="http://www.google.com/search?q=Mozilla&amp;ie=UTF-8&amp;oe=UTF-8&amp;hl=zh-TW&amp;lr=lang_zh-TW">http://www.google.com/search?q=Mozilla&amp;ie=UTF-8&amp;oe=UTF-8&amp;hl=zh-TW&amp;lr=lang_zh-TW</a>

<a href="http://www.google.com/search?q=Mozilla&amp;amp;ie=UTF-8&amp;amp;oe=UTF-8&amp;amp;hl=zh-TW&amp;amp;lr=lang_zh-TW">http://www.google.com/search?q=Mozilla&amp;amp;ie=UTF-8&amp;amp;oe=UTF-8&amp;amp;hl=zh-TW&amp;amp;lr=lang_zh-TW</a>
=============================

What you actually see versus what is actually used are two very different things. ;)

Comment 9

[David Boswell]

Ah, I understand.  OK, nevermind :)

Comment 10

[Roland Warmerdam]

Attachment: Fixed the link, underline styles and excluded the community/gen-ng-info file

Comment 11

[Reed Loden [:reed]]

(In reply to comment #2)
> * I'd include community/gen-ng-info as part of the patch for changes generated
> pages.  The person who owns that is different than from the straight HTML
> files.

Where are you putting this patch now? I can review it, too.

Comment 12

[Roland Warmerdam]

(In reply to comment #11)
> (In reply to comment #2)
> > * I'd include community/gen-ng-info as part of the patch for changes generated
> > pages.  The person who owns that is different than from the straight HTML
> > files.
> 
> Where are you putting this patch now? I can review it, too.

I removed the community/gen-ng-info and community/developer-forums.html files from this patch because bug #514619 already has a patch attached to it that contains these files with the same changes.

Comment 13

[Reed Loden [:reed]]

Thanks for the patch!

r52330