--enable-xpctools breaks build

RESOLVED FIXED

Status

()

Core
XPConnect
--
blocker
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Jory A. Pratt, Assigned: Jory A. Pratt)

Tracking

1.9.2 Branch
All
Linux
Points:
---
Bug Flags:
blocking1.9.2 -

Firefox Tracking Flags

(status2.0 unaffected, status1.9.2 .13-fixed, status1.9.1 unaffected)

Details

(Whiteboard: [qa-ntd-192])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

8 years ago
../../../../config/rules.mk:2268: *** Makefile variable 'REQUIRES' changed value after including rules.mk. Was 'xpcom string js caps necko dom  content editor layout rdf svg xuldoc xultmpl widget ', now xpcom string js caps necko dom  content editor layout rdf svg xuldoc xultmpl widget  xpctools..  Stop
Flags: blocking1.9.2?
(Assignee)

Comment 1

8 years ago
Created attachment 401726 [details] [diff] [review]
proposed fix
Attachment #401726 - Flags: review?(shaver)
Not blocking as this doesn't affect the release.
Flags: blocking1.9.2? → blocking1.9.2-
Attachment #401726 - Flags: review?(shaver) → review?(jim)

Updated

8 years ago
Attachment #401726 - Flags: review?(jim) → review+
Assignee: nobody → anarchy
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Patch doesn't apply on mozilla-central. See http://hg.mozilla.org/mozilla-central/rev/cc3240bc917a
Keywords: checkin-needed

Comment 4

8 years ago
Created attachment 444378 [details] [diff] [review]
updated
Attachment #401726 - Attachment is obsolete: true
Attachment #444378 - Flags: review+

Comment 5

8 years ago
http://hg.mozilla.org/venkman/rev/1c8f943af2fb
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 6

8 years ago
oops, sorry, wrong window.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

8 years ago
Attachment #444378 - Flags: approval1.9.2.9?
(Assignee)

Comment 7

7 years ago
Comment on attachment 444378 [details] [diff] [review]
updated

Clearing out 1.9.2.9, requesting 1.9.2.12
Attachment #444378 - Flags: approval1.9.2.9? → approval1.9.2.12?

Updated

7 years ago
status2.0: --- → unaffected

Updated

7 years ago
Attachment #444378 - Flags: approval1.9.2.12? → approval1.9.2.12+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
This patch doesn't applies on 1.9.2 branch. Jory, could you attach an updated patch?
(Assignee)

Comment 9

7 years ago
Created attachment 482163 [details] [diff] [review]
update patch for current merge

Updated patch that will apply to current state of tree.
Attachment #482163 - Flags: review+
Pushed:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/852c39d4fed7
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago7 years ago
status1.9.2: --- → .12-fixed
Resolution: --- → FIXED
Keywords: checkin-needed
Nothing for QA to do here for 1.9.2.
Whiteboard: [qa-ntd-192]

Updated

7 years ago
status1.9.1: --- → unaffected
You need to log in before you can comment on or make changes to this bug.