517787 - Clicking a partially off-screen link shouldn't scroll the page (again)

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Jesse Ruderman]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20090920 Firefox/3.7a1pre

This was fixed once before in bug 105894, but it's broken again.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

checking on the tryserver.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This should be a regression of the focus refactoring, we should fix this on 1.9.2 branch too.

Comment 3

[Neil Deakin]

Comment on attachment 401796 [details] [diff] [review]
Patch v1.0

>+<window title="Focus Scroll Tests"
>+  onload="setTimeout(runTest, 0);"

You should use SimpleTest.waitForFocus since retrieving fm.focusedElement will rely on the window being focused.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.1

thanks

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://hg.mozilla.org/mozilla-central/rev/6ae554d40a78

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 401863 [details] [diff] [review]
Patch v1.1

We should fix this regression on 1.9.2 branch too. The risk is low. This patch only suppresses the scrolling at clicking a link.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/445de6143f10

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.1 for 1.9.2 branch