517809 - Bespin will continue to grow, if no height is specified for parent.

Status: RESOLVED FIXED

(Skywriter Graveyard :: Editor, defect, P1)

Description

[Christian Sonne [:cers]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a2pre) Gecko/20090917 Ubuntu/9.04 (jaunty) Namoroka/3.6a2pre
Build Identifier: http://bitbucket.org/alexi/bespin/ f7ff038bcfcc+

Because the paint() method will try to match the size of the parent container, unless this is styled to an explicit height, Bespin will end up chasing an ever increasing height, until browser becomes unresponsive due to giant canvas element.

Reproducible: Always

Steps to Reproduce:
1. Use Bespin embedded on unstyled div (see attached test case)
Actual Results:  
Bespin grows 4px on each paint()

Expected Results:  
Bespin starts with default/minimum height

Comment 1

[Anders Bruun Olsen]

User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.2) Gecko/20090803 Ubuntu/9.04 (jaunty) Shiretoko/3.5.2

Confirmed.

Comment 2

[Kevin Dangoor]

There is other weird behavior if you're embedding an editor and you attach it 
to a node without a height. We should guard against this.

Here's another test for this:

take a Bespin Embedded package
edit sample.html
remove class="bespin" from the editor div
in the console, run:

embed = tiki.require("bespin:embed");
embed.useBespin("editor");

You won't see anything, because there's no height on the div. If you give the 
div a height via the DOM view in Firebug, you'll see the editor, but it will 
behave crazily.

Regardless, Bespin should make sure that it has a height.

Comment 3

[Kevin Dangoor]

Reassigning to Patrick. I think this *might* have been taken care of with the 
work that Patrick did, but I want to confirm.

Comment 4

[Gordon P. Hemsley [:GPHemsley]]

This bug had been targeted at a milestone that has already been released. Either this bug missed that milestone, or this bug was never closed after it had been fixed.

Please check to see which of the two it is and adjust this bug accordingly.

[This is a mass comment. To filter bugmail, use the term 'bespin-old-milestone'.]

Comment 5

[Julian Viereck]

This bug is fixed.

Comment 6

[Gordon P. Hemsley [:GPHemsley]]

Marking as RESOLVED FIXED, per comment 5. If anyone has a specific changeset or version number, please note it in a comment.