517819 - unknownContentType.xul download dialog has type of file selected

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Timothy Nikkel (:tnikkel)]

The unknownContentType.xul download dialog has the type of file selected (ie 'Binary file'). This happens for example when clicking on the first putty.exe download link in the URL. Bug 178324 caused the file type to have a visible cursor. Bug 508477 caused the whole field to be selected.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Neil, caused by the focus rewrite?

Comment 3

[Neil Deakin]

This bug is caused because there is a 

<textbox id="type" class="plain" readonly="true" flex="1"/>

at the top of the dialog and the code which sets initial focus finds it first. The solution is to do something like bug 513186 but handle textboxes as well (tricker as textbox.inputField is actually focused).

Or, we could just take the part of the second patch in that bug that fixes this as well.

Comment 4

[Neil Deakin]

Attachment: set noinitialfocus on the textbox and inherit it

Comment 5

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/d6a03e3e6e6f

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 406055 [details] [diff] [review]
set noinitialfocus on the textbox and inherit it

a192=beltzner, Neil, could you check this in?

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

1.9.2 approval for this expires at the end of the day (15 Dec) due to code freeze plans -- please land as soon as possible; if it bounces, it bounces hard.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 406055 [details] [diff] [review]
set noinitialfocus on the textbox and inherit it

I guess this missed the cut-off. Kind of disappointing.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

With Neil away until the 17th, can we get someone else to land this in the 1.9.2 branch for final?

Comment 11

[Shawn Wilsher :sdwilsh]

It would need approval first.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Is there a separate fix needed for Mac?  This still happens with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a2pre) Gecko/20100223 Minefield/3.7a2pre.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 406055 [details] [diff] [review]
set noinitialfocus on the textbox and inherit it

a1922=beltzner

Stephend - do you mean it's not fixed on OSX on 3.6 or trunk?

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #13)
> (From update of attachment 406055 [details] [diff] [review])
> a1922=beltzner
> 
> Stephend - do you mean it's not fixed on OSX on 3.6 or trunk?

Both.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

As per comment 12.

Neil, I'll leave it to you if you want to open a different bug for OSX or if you want to just make it part of this one.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

The patch wasn't platform-specific, so if this is still a problem on OS X (I can't reproduce), it should be filed as a new bug.

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #16)
> The patch wasn't platform-specific, so if this is still a problem on OS X (I
> can't reproduce), it should be filed as a new bug.

I just reopened bug 520449, which was duped to this.

Comment 18

[Neil Deakin]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/110a1591e7d1

Comment 19

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on 1.9.2 with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.2) Gecko/20100316 Firefox/3.6.2 (.NET CLR 3.5.30729)