517896 - Stop button does not show up on page loads

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aakash Desai [:aakashd]]

Build Id:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090921 Fennec/1.0a3

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2a2pre) Gecko/20090921
Fennec/1.0b4pre


Steps to Reproduce:
1. Go to any webpage
2. Take a look at where the stop button should be

Actual Results:
The reload button is shown on pageloads

Expected Results:
The stop button should be shown

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Stop button shows up fine for me on n900

Comment 2

[Aakash Desai [:aakashd]]

What build Id are you using, Mark?

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

my bad - crazy littles typos!

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 401869 [details] [diff] [review]
Patch

Found an other bug I want to correct with this one

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #4)
> (From update of attachment 401869 [details] [diff] [review])
> Found an other bug I want to correct with this one

Too late - file a new bug

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/438c012799e6

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

This one turn the button back to 'loading' state when we load a big website (eg: espn.com), go to the awesomebar, close the awesomebar.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed patch 2:
https://hg.mozilla.org/mobile-browser/rev/f933499c8d99

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090922 Fennec/1.0a3

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2a2pre) Gecko/20090922
Fennec/1.0b4pre