Created attachment 401988 [details] [diff] [review] Patch This builds on bug 512591 by allowing any test(s) to be run with valgrind. It adds an option --valgrind-all that runs all tests under valgrind. This option also enables --show-output because otherwise it's kind of pointless. :-)
Attachment #401988 - Flags: review?(graydon)
Actually the patch I committed had a small-n-subtle change to redirect *stderr* only when the test.valgrind condition is set. This is what you want rather than blunt enabling of --show-output; we have some tests that --show-output will cause to spew hundreds of pages of trace chatter (those that test logging). If you remove that hunk though, this patch looks fine.
Comment on attachment 401988 [details] [diff] [review] Patch all but the last hunk
Attachment #401988 - Flags: review?(graydon) → review+
Missed that. Pushed to TM with fix as 886a447d6a8f.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
status1.9.2: --- → beta1-fixed
You need to log in before you can comment on or make changes to this bug.