TM: trace-test.py: option to run any test case under valgrind

RESOLVED FIXED

Status

()

Core
JavaScript Engine
--
enhancement
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dmandelin, Assigned: dmandelin)

Tracking

Trunk
Points:
---
Bug Flags:
wanted1.9.2 +
in-testsuite -

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 401988 [details] [diff] [review]
Patch

This builds on bug 512591 by allowing any test(s) to be run with valgrind. It adds an option --valgrind-all that runs all tests under valgrind. This option also enables --show-output because otherwise it's kind of pointless. :-)
Attachment #401988 - Flags: review?(graydon)

Updated

9 years ago
Attachment #401988 - Attachment is patch: true
Attachment #401988 - Attachment mime type: application/octet-stream → text/plain
Actually the patch I committed had a small-n-subtle change to redirect *stderr* only when the test.valgrind condition is set. This is what you want rather than blunt enabling of --show-output; we have some tests that --show-output will cause to spew hundreds of pages of trace chatter (those that test logging).

If you remove that hunk though, this patch looks fine.
Comment on attachment 401988 [details] [diff] [review]
Patch

all but the last hunk
Attachment #401988 - Flags: review?(graydon) → review+
(Assignee)

Comment 3

9 years ago
Missed that. Pushed to TM with fix as 886a447d6a8f.
Whiteboard: fixed-in-tracemonkey

Comment 4

9 years ago
http://hg.mozilla.org/mozilla-central/rev/886a447d6a8f
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 5

9 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3667ede3433d
status1.9.2: --- → beta1-fixed
Flags: wanted1.9.2+

Updated

9 years ago
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.