518056 - TM: trace-test.py gives unhelpful error message if non-existent shell is specified

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

An example:

> python trace-test/trace-test.py no_such_file
Traceback (most recent call last):
  File "trace-test/trace-test.py", line 296, in <module>
    run_tests(test_list, test_dir, lib_dir)
  File "trace-test/trace-test.py", line 148, in run_tests
    ok, out, err = run_test(test, lib_dir)
  File "trace-test/trace-test.py", line 109, in run_test
    p = Popen(cmd, stdin=PIPE, stdout=PIPE, stderr=PIPE, close_fds=close_fds, env=env)
  File "/usr/lib/python2.6/subprocess.py", line 595, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1092, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory


It's not high priority, but would be nice -- I just hit this and it took a couple of minutes of head-scratching to work out what was wrong.

Comment 1

[David Mandelin [:dmandelin]]

Attachment: Patch

Comment 2

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/0a6c7019a559

Comment 3

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/fcf3933d223c