518075 - explore longer sync intervals + syncing based on trackers

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Mike Connor [:mconnor]]

Attachment: WIP

just some stuff I've been thinking about for a while, sticking it here so I don't forget (yay plane hacking)

Comment 1

[Mike Connor [:mconnor]]

Attachment: current

to-do:

* figure out right threshold values
* figure out how this plays better with different user sync types

Comment 2

[Ed Lee :Mardak]

One potential issue is that users can sync (much) more often than the normal sync intervals. So single client mode could trigger many more than just once-a-day syncs.

Comment 3

[Ed Lee :Mardak]

Attachment: combine with patch from bug 517597

Comment 4

[Mike Connor [:mconnor]]

The amount of records needed to get to a score of 1000 is pretty high, but the point is fair.  We can tweak the threshold values to be whatever we want, as well as adjusting the scores per-engine.  The main point is to define an amount of data that's "big enough" to justify an early sync in the various cases, given that the single user case is largely "backup" we want to make sure the delta between saved and not-saved never too high.

Comment 6

[Mike Connor [:mconnor]]

http://hg.mozilla.org/labs/weave/rev/53769570c48a
land this with tweaked item values.

Clearing history/passwords will force a sync based on current values, which is desired behaviour.

Comment 7

[Ed Lee :Mardak]

9.7 +  get syncThreshold() Svc.Prefs.get("syncThreshold", SINGLE_USER_THRESHOLD),
9.8 +  set syncThreshold(value) Svc.Prefs.set("nextSync", value),
probably meant set("syncThreshold", .. ?

9.44 +  _handleScoreUpdate: function WeaveSvc__handleScoreUpdate() {
9.45 +    const SCORE_UPDATE_DELAY = 3000;
9.46 +    if (this._scoreTimer) {
9.47 +      this._scoreTimer.delay = SCORE_UPDATE_DELAY;
9.48 +      return;
9.49 +    }
9.50 +    else {
9.51 +      Utils.delay(function() this._doGS(), SCORE_UPDATE_DELAY, this, "_scoreTimer");
9.52 +    }
9.53 +  },
I believe the first if block is unnecessary as delay() will basically do timer.delay = DELAY. Just checking you weren't trying to do something different?

Comment 8

[Mike Connor [:mconnor]]

Oh, I didn't look into the internals of Utils.delay(), I just wanted to make it work since the old patch bitrotted.  We can certainly change that now. :)

Comment 9

[Mike Connor [:mconnor]]

http://hg.mozilla.org/labs/weave/rev/a8a4fe9267ae
fix this, and fix globalScore growing too fast...