Mistake in overlay.properties file from builder

VERIFIED FIXED in 5.1

Status

addons.mozilla.org Graveyard
Developer Pages
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: clouserw, Assigned: cesar)

Tracking

unspecified

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
From an email:

I recently tested the online automatic addon build, which is pretty cool,
execept for one detail. The localized description hack is Ok in the defaults folder, but there is a mistake in the corresponding locale/en-US/overlay.properties file

it says :
extensions.extension_name.description=description
it should be
extensions.extension_ID.description=description 
as grabbed from the install.rdf
(Assignee)

Comment 1

8 years ago
Created attachment 402532 [details] [diff] [review]
v1

This is a fizzypop back-end bug. Additionally, the prefs.js file points to an invalid chrome url. It should point to overlay.properties since we don't use dynamic filenames.
Attachment #402532 - Flags: review?(mark.finkle)
Attachment #402532 - Flags: review?(mark.finkle) → review+
Committed in r52422, thanks Cesar!
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 3

8 years ago
I have created new add-on, with no description. I have opened /chrome/locale/en-US/, there was 
> extensions.milos@mozillasrbija.org.description=description 
standing there (milos@mozilla-srbija.org is my addon ID). So, i have installed add-on, and in Add-ons manager I could see "description" under add-on's name. After that, I have changed last word(description) in to 
> extensions.milos@mozillasrbija.org.description=Neki moj opis
, installed add-on again, and I got "Neki moj opis" as a actual description of my add-on.

Verified. Thanks Cesar!
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.