Closed Bug 518121 Opened 14 years ago Closed 14 years ago

_selectItem should be set to null when we enter the awesomebar

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
fennec1.0b4

People

(Reporter: vingtetun, Assigned: vingtetun)

Details

Attachments

(1 file)

Patch
636 bytes, patch
Gavin
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
When we close the awesomebar we set a var called _selectItem for user perception for the long time closing awesomebar lag.

Once we select the 'All bookmarks' row, setting this 'var' force the urlbar to always select the 'All bookmarks' item while nothing else has been selected.

Steps to reproduce:
 * Go to the awesomebar
 * Click on the All bookmarks row
 * Quit the bookmarks list
 * Go to the awesomebar and enter a search term
 * press enter

Actual results:
 * The bookmarks list is displayed!

Expected results:
 * a webpage
Attachment #402087 - Flags: review?(gavin.sharp)
Comment on attachment 402087 [details] [diff] [review]
Patch

good catch!
Attachment #402087 - Flags: review?(gavin.sharp) → review+
pushed:
https://hg.mozilla.org/mobile-browser/rev/81a58085c7ce
Assignee: nobody → 21
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → B4
verified FIXED ON builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2a2pre) Gecko/20090923 Fennec/1.0a3

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2a2pre) Gecko/20090923
Fennec/1.0b4pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.