518169 - Setting currentTime while video is in stop state doesn't seek video anymore

Status: VERIFIED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: testcase

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b1pre) Gecko/20090922 Namoroka/3.6b1pre

There is another regression from the work on bug 501031. I noticed that too while working on the Mozmill video test (bug 489474) from Mikeal. It's another regression.

Steps:
1. Open the testcase
2. Wait around 1-2s and check that the scrubber is not positioned to 6s.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch v1

Problem was with bounds check on the seek. When we seek, we calculate the timestamp at the extremities of the byte range we're seeking in by taking the granulepos' timestamp from the first and last page in the range. Unfortunately the granulepos corresponds to the end time of the last sample in that page, so if the seek target lies before that, it's assumed to be outside of the buffered range, and so the seek fails. This is particularly a problem at the start of media; if the seek target lies before the end of the first page, we'll assume it's not in the [0..end] range, and the seek fails. The fix is to assume the byte-range start time is 0 when the byte-range begins at the start of a media.

I also missed resetting some oggz internal data fields on some exit-paths on failure.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/1ecaf8a4c05a

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Should be easy enough to make a testcase, just need to seek to a time which is less than the end-time of the first ogg page.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Pushed to 1.9.2: http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a5acfd2831e0

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed on trunk and 1.9.2 with builds on OS X and the given Mozmill video test:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091003 Minefield/3.7a1pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b1pre) Gecko/20091003 Namoroka/3.6b1pre