icon fixes for account central

RESOLVED FIXED in Thunderbird 3.0rc1

Status

Thunderbird
General
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: clarkbw, Assigned: clarkbw)

Tracking

({polish})

Trunk
Thunderbird 3.0rc1
polish

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 402158 [details] [diff] [review]
aligns text to the center and gives minimum height needed for icons

+++ This bug was initially created as a clone of Bug #512460 +++

Spinning off this bug from bug 512460 comment #12 in order to fix the account central icons that are mis-aligned.  I'd call this a medium priority polish bug, I don't want to release with this as is but I can't see blocking the release if I didn't get this patch done.

The included patch fixes this problem in in gnomestripe and qute though I haven't had a chance to test the qute part just yet.  The patch is pretty straight forward as I remove all the padding declarations from the individual labels and change the top/bottom to margins in the class selector.  The min-height attribute ensures that the icons aren't inadvertently cropped by small text.

Will test this on windows a little bit but I wanted to get this on the review queue quickly.
Attachment #402158 - Flags: review?(mkmelin+mozilla)
(Assignee)

Comment 1

8 years ago
Created attachment 402159 [details] [diff] [review]
how about the correct patch

will the real patch version please stand up
Attachment #402158 - Attachment is obsolete: true
Attachment #402159 - Flags: review?(mkmelin+mozilla)
Attachment #402158 - Flags: review?(mkmelin+mozilla)

Comment 2

8 years ago
Comment on attachment 402159 [details] [diff] [review]
how about the correct patch

Sure, r=mkmelin
Attachment #402159 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Updated

8 years ago
Attachment #402159 - Flags: approval-thunderbird3?
Attachment #402159 - Flags: approval-thunderbird3? → approval-thunderbird3+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/b798ddde2d8c
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.