Closed Bug 518308 Opened 12 years ago Closed 12 years ago
Axis should not lock a direction if we can't scroll it
In general we disallow horizontal scroll for chrome UI, but lockAxis can lock the direction on the X axis depending how the movement is started. If there is only one direction scrollable/pannable we should lock the axis in this direction. Steps to reproduce: * launch fennec and go to the awesome screen * start a pan by moving on the X axis Actual results: * scroll is locked in the wrong direction Expected results: * we scroll in the only scrollable direction
Attachment #402317 - Flags: review?(combee)
Comment on attachment 402317 [details] [diff] [review] Patch I like the idea, but we don't need to track both axis. If we can't scroll one, then locking doesn't matter. We should just set the "alreadyLocked" flag early with no locked values.
Address comments and use a flag called _unidirectionalLock
Sorry for the spam... Because alreadyLocked is public I think it's better to not alter the lockAxis prototype and directly set the alreadyLocked attribute.
Comment on attachment 402567 [details] [diff] [review] Patch v0.3 I'm happy with this.
Attachment #402567 - Flags: review?(combee) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
verified with 20091221 1.9.2 nightly on my n900. I verified a lock on x and y axis as well as the ability to move diagonal and random. Both during normal mode and zoom mode.
Status: RESOLVED → VERIFIED
litmus testcase https://litmus.mozilla.org/show_test.cgi?id=11532 takes care of this bug
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.