shorten height of bookmarks header

VERIFIED FIXED in fennec1.0b4

Status

Firefox for Android Graveyard
Bookmarks
VERIFIED FIXED
9 years ago
5 years ago

People

(Reporter: madhava, Assigned: mfinkle)

Tracking

Trunk
fennec1.0b4
x86
Mac OS X

Details

(Whiteboard: [polish])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

9 years ago
Created attachment 402332 [details]
bookmarks header height

The bookmarks header is taller than a 7mm touch height, as you can see in the attached image.  It's this height because it matches the height of the titlebar in the main view, but it looks out of place here.

We can bring the height down to match the other rows on the screen.  This will require making the button shorter than others, but it should still be tappable.

See the attached image.
(Reporter)

Updated

9 years ago
tracking-fennec: --- → ?
Whiteboard: [polish]
Created attachment 402571 [details] [diff] [review]
patch

Bug 518470 reduced the height of buttons, which affects this bug. Bug 518470 also reduced the padding in the url and searchbars.

This patch only reduces the top/bottom padding in the bookmarks header, which coupled with bug 518470, reduces the bookmarks header height to ~6mm - roughly a row height.
Assignee: nobody → mark.finkle
Attachment #402357 - Attachment is obsolete: true
Attachment #402571 - Flags: review?(gavin.sharp)
Attachment #402571 - Flags: review?(gavin.sharp) → review+
pushed:
https://hg.mozilla.org/mobile-browser/rev/ad2268a344f0
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → B4
verified FIXED On builds:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20090925
Fennec/1.0b4pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20090925
Fennec/1.0b4pre
Status: RESOLVED → VERIFIED
Component: General → Bookmarks
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.