download manager: retry button always visible

VERIFIED FIXED in fennec1.0b5

Status

Firefox for Android Graveyard
General
VERIFIED FIXED
9 years ago
5 years ago

People

(Reporter: madhava, Assigned: mfinkle)

Tracking

Trunk
fennec1.0b5
x86
Mac OS X

Details

(Whiteboard: [polish])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

9 years ago
See here:  http://www.flickr.com/photos/42739110@N07/3948019548/in/photostream/


In that screenshot, the first row is selected, which is why the row's buttons are revealed.  The second and third row are not selected, so the buttons should be hidden and the row collapsed to its normal height.  The "Retry" button is always visible.
(Reporter)

Updated

9 years ago
tracking-fennec: --- → ?
Whiteboard: [polish]
Agreed, I'm seeing this on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20090925 Fennec/1.0a3

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20090925
Fennec/1.0b4pre

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20090925
Fennec/1.0b4pre
Created attachment 404553 [details] [diff] [review]
patch

This hides the button unless the item is selected as requested, but this raises a different question - the downloads in question have failed or have been canceled, and there's no good indication that that's the case (the button wasn't ideal, but it was _something_, at least).
Comment on attachment 404553 [details] [diff] [review]
patch

I like this and I have a patch that builds on this.
Attachment #404553 - Flags: review+
Created attachment 404692 [details] [diff] [review]
patch 2 (adds a 'failed' label)

This patch builds on the first and adds a "Failed" label to the row when it is not selected.
Assignee: nobody → mark.finkle
Attachment #404553 - Attachment is obsolete: true
Attachment #404692 - Flags: review?(gavin.sharp)
Created attachment 404693 [details] [diff] [review]
the diff

this is the diff between the two patches
Attachment #404692 - Flags: review?(gavin.sharp) → review+
pushed:
https://hg.mozilla.org/mobile-browser/rev/63d20eed1e3b
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → B5
verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20091007
Fennec/1.0b4

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091007
Fennec/1.0b4
Status: RESOLVED → VERIFIED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.