518370 - fit 4 tabs high on the n900

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

In terms of touchheights (7mm) there should be room for a column of 4 independently touchable tab thumbnails.  At the moment, they're spaced such that we only fit 3 high:

see here:  http://www.flickr.com/photos/42739110@N07/3947216887/in/photostream/

If we reduce the vertical spacing I think we can fit them without adjusting the thumbnail size itself (though that's also an option).

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This reduce a bit the border around a selected tab (from 1mm to 0.65mm) and the vertical spacing.

Madhava, is the border reduction ok?

Comment 2

[Madhava Enros [:madhava]]

Can you post a screenshot?  When I went through it in photoshop, it looked like it was possible to fit four just by adjusting the spacing.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: screenshot with reduce border

Not sure why border of 0.8mm works now.

The space between the last tab and the newTab button is a 1mm margin

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

madhava, do you want me to try to reduce the margin instead of the tabs borders?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(I mean the margin between the last tab and the newTab button)

Comment 6

[Madhava Enros [:madhava]]

No, I think that distance is fine.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: 0.8mm borders

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch with 0.8mm borders for hildon

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/1c5d3f8b62cb

Comment 10

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091015
Fennec/1.0b5pre

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

From Aakash Desai:

This needs to be re-opened as this is happening on 1.9.2 branch and trunk winmo
builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20091016
Fennec/1.0a4pre

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20091016
Fennec/1.0a4pre

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Sounds like we need to land this patch for WinMo too

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

FIXED for Maemo.

Bug 523218 is for Windows Mobile.

Comment 14

[Aakash Desai [:aakashd]]

Cool, I can go ahead and verify this on maemo:

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091019
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091019
Fennec/1.0b5pre

Comment 15

[Al Billings [:abillings - ex-MoCo]]

in-litmus+

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=9766