518438 - [de] Different (false) quotation marks

Status: RESOLVED FIXED

(Mozilla Localizations :: de / German, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

As a follow up to an other bug. I've been searching in all German locale files for different quotation marks.

IMHO we should use the quotation mark ". But we're using both " and the apostrophe '.

I'm not sure, how to fix this. DTD files are using the " at the beginning and end of every entity. Would it be necessary (and possible?) to encode the quotation marks? AFAIK in DTD files we could use the ' at the beginning and end of an entity, but would this be a practicable solution? KaiRo what does MozillaTranslator with our " quotation marks, when you're saving/exporting the DTD files?
In *.properties files the " quotation marks are no (technical) problem.

Comment 1

[Robert Kaiser]

We need to use " in DTDs, and I think it should work everywhere.

Comment 2

[Kadir Topal [:atopal]]

Makes sense, di you want to take this, Alexander?

Comment 3

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #2)
> Makes sense, di you want to take this, Alexander?

Taking over

Comment 4

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Patch v1 - excluding venkman and inspector

Comment 5

[Alex Ihrig [:Thunderbird_Mail_DE]]

FYI: The patch has a lot of "hidden" changes, because of removing spaces at the end of lines.

Comment 6

[Kadir Topal [:atopal]]

Comment on attachment 503466 [details] [diff] [review]
Patch v1 - excluding venkman and inspector

It looks like almost half of the changes are those 'hidden' changes, but the other half looks good ;)

Comment 7

[Robert Kaiser]

Comment on attachment 503466 [details] [diff] [review]
Patch v1 - excluding venkman and inspector

whatever. will require a lot of work to get my in-MT stuff synched up with this, but what's this world without such fun, right? ;-)

I don't like the changes that seem to apply something to comments where the actual change can't be seen here, please don't apply those or explain what they actually are. If they e.g. introduce non-unix linebreaks or such (can't tell from just looking at Bugzilla) then they're inacceptable, if they clean up such things, they probably should be done in their own bug.

Comment 8

[Alex Ihrig [:Thunderbird_Mail_DE]]

1) No linebreak changes (UltraEdits pref is set to save edited files in the original format)
2) The only change in these hidden line changes are deleted spaces/tabs at line endings

Comment 9

[Robert Kaiser]

(In reply to comment #8)
> 2) The only change in these hidden line changes are deleted spaces/tabs at line
> endings

Couldn't spot those in the example(s) I looked at in the patch - still, my tools will probably add them back in files I manage/edit if they are present in the original en-US versions as well. And I still am not sure if it's a good idea to check them in mixed between the actual changes here.

Comment 10

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: [checked in] Patch v2 - excluding calendar, suite and venkman/inspector

Patch v2 removes all "hidden" changes. Separate patches for calendar and suite will follow.

Comment 11

[Kadir Topal [:atopal]]

Comment on attachment 503568 [details] [diff] [review]
[checked in] Patch v2 - excluding calendar, suite and venkman/inspector

Much better :)

Comment 12

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: [checked in] Patch v2 - calendar part

Comment 13

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: [checked in] Patch v2 - suite part

Comment 14

[Alex Ihrig [:Thunderbird_Mail_DE]]

Fx part checked in:
http://hg.mozilla.org/l10n-central/de/rev/3057612f2161

Suite part checked in:
http://hg.mozilla.org/l10n-central/de/rev/b1548f13abd7

Comment 15

[Alex Ihrig [:Thunderbird_Mail_DE]]

Missing replacement in suite part:
http://hg.mozilla.org/l10n-central/de/rev/ff94642c47bf

Comment 16

[Alex Ihrig [:Thunderbird_Mail_DE]]

In venkman and chatzilla I can find many ' and '' and ``. I'm not sure if a part of these signs are used for formating purposes in chatzilla(s GUI). Additional there are some strings beginning with ''%S without an ending quotation?! So this part should be done by Robert.

Comment 17

[Robert Kaiser]

(In reply to comment #16)
> In venkman and chatzilla I can find many ' and '' and ``. I'm not sure if a
> part of these signs are used for formating purposes in chatzilla(s GUI).
> Additional there are some strings beginning with ''%S without an ending
> quotation?! So this part should be done by Robert.

I followed what the original strings have there, and with the strange L10n stuff they have, I have no clue what of those they actually need or not, so I don't really dare to touch that stuff.

Comment 18

[Robert Brand]

Comment on attachment 503668 [details] [diff] [review]
[checked in] Patch v2 - calendar part

My first patch to review is a hard one! ;-) Thanks, Alexander.

Comment 19

[Alex Ihrig [:Thunderbird_Mail_DE]]

Calendar part checked in:
http://hg.mozilla.org/l10n-central/de/rev/fa0d1e7bc92d

Venkman and chatzilla are remaining, other parts are fixed.

Comment 20

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

opi123, please top changing the status of bugs - at least most of them are still valid.

Comment 21

[u597032]

I'm sorry, but for me it is as it should be. So what should I mark the bug as?