TM: high-level CSE of shape guards

RESOLVED FIXED in mozilla1.9.2

Status

()

Core
JavaScript Engine
P1
normal
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: brendan, Assigned: brendan)

Tracking

unspecified
mozilla1.9.2
Points:
---
Dependency tree / graph
Bug Flags:
wanted1.9.2 ?

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 5 obsolete attachments)

(Assignee)

Description

9 years ago
This is not enough to fix the richards meta-bug 504587. But it is a good change.

/be
(Assignee)

Updated

9 years ago
Status: NEW → ASSIGNED
Flags: wanted1.9.2?
(Assignee)

Comment 1

9 years ago
Created attachment 402447 [details] [diff] [review]
patch
Attachment #402447 - Flags: review?(jorendorff)
(Assignee)

Comment 2

9 years ago
Created attachment 402451 [details] [diff] [review]
fix comment
Attachment #402447 - Attachment is obsolete: true
Attachment #402451 - Flags: review?(jorendorff)
Attachment #402447 - Flags: review?(jorendorff)
Comment on attachment 402451 [details] [diff] [review]
fix comment

I can't find a thing wrong with this.
Attachment #402451 - Flags: review?(jorendorff) → review+
(Assignee)

Comment 4

9 years ago
Created attachment 402907 [details] [diff] [review]
refreshed patch
Attachment #402451 - Attachment is obsolete: true
Attachment #402907 - Flags: review+
(Assignee)

Comment 5

9 years ago
http://hg.mozilla.org/tracemonkey/rev/f5ea964eb493

/be
Whiteboard: fixed-in-tracemonkey

Comment 6

9 years ago
I had to back this out, as it caused Windows leak test builds to hang. No good diagnostics.
Keywords: 4xp
Whiteboard: fixed-in-tracemonkey

Updated

9 years ago
Keywords: 4xp
(Assignee)

Comment 7

9 years ago
Created attachment 403289 [details] [diff] [review]
refreshed patch
Attachment #402907 - Attachment is obsolete: true
(Assignee)

Comment 8

9 years ago
Created attachment 403316 [details] [diff] [review]
refreshed patch
Attachment #403289 - Attachment is obsolete: true
(Assignee)

Comment 9

9 years ago
Created attachment 403677 [details] [diff] [review]
fixed patch (DEBUG-only windows breakage, duh!)

As jorendorff wrote, not a thing wrong with it (Windoze sucks man! ;-).

/be
Attachment #403316 - Attachment is obsolete: true
Attachment #403677 - Flags: review+
(Assignee)

Comment 10

9 years ago
http://hg.mozilla.org/tracemonkey/rev/b0d906da856a

/be
Whiteboard: fixed-in-tracemonkey
Depends on: 520161

Comment 11

9 years ago
http://hg.mozilla.org/mozilla-central/rev/b0d906da856a
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.