518456 - Add non-js fallback for favorites link

Status: VERIFIED FIXED

(Websites Graveyard :: getpersonas.com, defect, P2)

Description

[Carsten Book [:Tomcat]]

During the Tests i was running in 2 cases into a nearly empty site with just a "1" on it 

As example was trying to add http://sm-personas01.mozilla.org/persona/49 and that resulted in http://sm-personas01.mozilla.org/en-US/favorite/49/81eb8fba61ac72f6f2bfb2f6535bc0f0?action=1

Seems only happen from time to time it seems - happened to me twice - but worked in all other cases.

Comment 1

[Ryan Doherty (:rdoherty)]

This probably happened when the JS hadn't loaded yet and you clicked on the link. We should add a non-js fallback.

Comment 2

[Ryan Doherty (:rdoherty)]

Moving bugs necessary for 3.6 to new milestone.

Comment 3

[Ryan Doherty (:rdoherty)]

r58742

If js is off or hasn't loaded before the user clicks on the favorite link, it will reload the page and un/favorite the design. I think this is acceptable for the tiny majority of users who will experience this issue.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using JS disabled/enabled on http://personas.stage.mozilla.com/en-US/gallery/All/Favorites, with both the add/remove cases -- only tested in Firefox 3.5/3.6.

Tomcat -- as per usual, please reopen if you still see this issue from time to time (noting comment 3), thanks!