518463 - JS_GetStringBytes/Chars replacements

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Just in case any JSAPI clients are interested in correct behavior (or at least not-randomly-weird behavior) on OOM. ctypes for instance.

The proposed APIs are:

// Always returns a null-terminated string on success. Reports OOM and
// returns NULL on failure.
const jschar *
JS_GetStringCharsZ(JSContext *cx, JSString *str);

// Same.
const char *
JS_GetStringBytesZ(JSContext *cx, JSString *str);

Trivial to implement.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 402916 [details] [diff] [review]
v1

The right thing. Thanks,

/be

Comment 3

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/tracemonkey/rev/df46957a46f1

Comment 4

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/df46957a46f1