518467 - zooming and clicking near page border creates yellow border around page

Status: VERIFIED WORKSFORME

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Geoff Gustafson]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.14) Gecko/2009090905 Fedora/3.0.14-1.fc10 Firefox/3.0.14
Build Identifier: mozilla-1.9.2 plus mobile hg commit 916

You can reproduce this issue currently with these steps:
1) Load google.com
2) Double click on "Images" link in top left corner
3) Click within a pixel or two of the top left corner
4) A yellow border appears around the page and some fill area at the bottom of the page.

The yellow seems to match the yellow used for link highlighting, perhaps this is an interaction of zoom functionality and the link highlighting somehow.

It seems to me that immediately after a zoom, the visible part of the border area of the page reacts to clicks in this way. If you scroll to another part of the border, clicking there no longer causes it.

I'm doing this on desktop, but stechz and vingtetun have reproduced this as well.


Reproducible: Always

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This come from patch on bug 515362 which uses setFocus(element, ...) on any element, even if it was a body/div/...

I think we should check if 'element' has any reason to be focus : for example it is a link, a form element, ...

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch allow setFocus to be called on :
 * <a />
 * <input type="*" />
 * <button />
 * <select />

I've not done the support for <textarea /> because I don't think that was useful but I could easily add it.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 402485 [details] [diff] [review]
Patch

we no longer call .setFocus

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

This must be fixed by the backout of an earlier patch

Comment 6

[Aakash Desai [:aakashd]]

If this is fixed due to a backout, then the bug was fixed and this is verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b3pre) Gecko/20091111 Firefox/3.6b2pre Fennec/1.0b5

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091111 Firefox/3.7a1pre Fennec/1.0b5

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Bugs are FIXED only if we know which patch fixed them.