Closed
Bug 518477
Opened 15 years ago
Closed 15 years ago
NJ merge: LIR.{cpp,h} changes from TR
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | beta1-fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
5.85 KB,
patch
|
graydon
:
review+
|
Details | Diff | Splinter Review |
This patch absorbs all the LIR.{cpp,h} changes from TR that I'm certain TM
should take. (Most of the remaining diffs TR should take from TM, and
there are some I'm not sure about.)
- compile(): the Allocator& arg can be verbose-only.
- _bytesAllocated(0) isn't necessary because it gets initialised in clear().
- insGuard(): remove unnecessary whitespace.
- Removed two not-very-useful NanoAssert(0) statements which Rick said cause
problems on windows (see bug 518034 comment 2).
- Changes !i->isCse() to i->isStmt() in live(); this changes the
TMFLAGS=liveness output greatly, but !i->isCse() was just flat-out wrong.
Attachment #402486 -
Flags: review?(graydon)
|
||
Updated•15 years ago
|
Attachment #402486 -
Flags: review?(graydon) → review+
|
Assignee | |
Comment 1•15 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/1561f6e7afcb
Whiteboard: fixed-in-tracemonkey
|
||
Comment 2•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1561f6e7afcb
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/f19a66369645
status1.9.2:
--- → beta1-fixed
Flags: wanted1.9.2+
You need to log in
before you can comment on or make changes to this bug.
Description
•