NJ merge: Assembler bits and pieces

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

Trunk
x86
Linux
Points:
---
Bug Flags:
wanted1.9.2 +

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 402509 [details] [diff] [review]
patch

The patch:

- Moves some Assembler method declarations around (asm_pusharg(), asm_arg()) and
  removes a dead one (asm_short()).

- Removes asm_arg() from NativeARM.cpp, which moves us away from TR in the
  short-term but will make the merge easiler in the long-term because TR has
  a similar-but-different copy of asm_arg() that will now be able to be
  removed.

- Removes an unnecessary NanoAssert(0) that slipped in by accident on a
  previous commit of mine.

- Changes an LIR_iaddp to LIR_addp which pairs nicely with the adjacent
  LIR_alloc.

- Adds a tweak to asm_quad().
Attachment #402509 - Flags: review?(graydon)

Updated

8 years ago
Attachment #402509 - Flags: review?(graydon) → review+
(Assignee)

Comment 1

8 years ago
http://hg.mozilla.org/tracemonkey/rev/a16cb20541f4
Whiteboard: fixed-in-tracemonkey

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/a16cb20541f4
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 3

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/a26242de11ea
status1.9.2: --- → beta1-fixed
Flags: wanted1.9.2+
You need to log in before you can comment on or make changes to this bug.