518550 - Crash [ gfxPlatformGtk::InitDisplayCaps ] on maemo/hildon scratchbox after landing 449283

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Oleg Romashin (:romaxa)]

"/proc/component_version" not available on scratchbox

#0  0xb751ac1c in gfxPlatformGtk::InitDisplayCaps (this=0x9a44190)
    at mozilla/gfx/thebes/src/gfxPlatformGtk.cpp:579
579	            if (NS_SUCCEEDED(lineStream->ReadLine(buffer, &isMore))) {
(gdb) bt
#0  0xb751ac1c in gfxPlatformGtk::InitDisplayCaps (this=0x9a44190)
    at mozilla/gfx/thebes/src/gfxPlatformGtk.cpp:579
#1  0xb7463ebc in nsThebesDeviceContext::SetDPI (this=0x997d668) at ../../../dist/include/gfxPlatform.h:315
#2  0xb74649a4 in nsThebesDeviceContext::Init (this=0x997d668, aWidget=0x0)
    at mozilla/gfx/src/thebes/nsThebesDeviceContext.cpp:725
#3  0xb74525d2 in nsBaseWidget::BaseCreate (this=0x9a43fa8, aParent=0x0, aRect=@0xbfa8fb8c, 
    aHandleEventFunction=0xb73045e0 <nsWebBrowser::HandleEvent(nsGUIEvent*)>, aContext=0x0, aAppShell=0x0, aToolkit=0x0, aInitData=0xbfa8fb44)
    at mozilla/widget/src/xpwidgets/nsBaseWidget.cpp:200
#4  0xb7440cfe in nsWindow::NativeCreate (this=0x9a43fa8, aParent=0x0, aNativeParent=0x979b590, aRect=@0xbfa8fb8c, 
    aHandleEventFunction=0xb73045e0 <nsWebBrowser::HandleEvent(nsGUIEvent*)>, aContext=0x0, aAppShell=0x0, aToolkit=0x0, aInitData=0xbfa8fb44)
    at mozilla/widget/src/gtk2/nsWindow.cpp:3848
#5  0xb7441acd in nsWindow::Create (this=0x9a43fa8, aParent=0x979b590, aRect=@0xbfa8fb8c, 
    aHandleEventFunction=0xb73045e0 <nsWebBrowser::HandleEvent(nsGUIEvent*)>, aContext=0x0, aAppShell=0x0, aToolkit=0x0, aInitData=0xbfa8fb44)
    at mozilla/widget/src/gtk2/nsWindow.cpp:640
#6  0xb7306ef4 in nsWebBrowser::Create (this=0x99f5878)
    at mozilla/embedding/browser/webBrowser/nsWebBrowser.cpp:1139
#7  0xb7771030 in EmbedWindow::CreateWindow (this=0x99d4838) at ../../src/EmbedWindow.cpp:105

(gdb) p lineStream
$1 = {<nsCOMPtr_base> = {mRawPtr = 0x0}, <No data fields>}
Current language:  auto; currently c++

Comment 1

[Oleg Romashin (:romaxa)]

Also some white-space:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ea32b873533c#l12.43

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

What DPI should be reported when running on Scratchbox? 96?

Comment 3

[Oleg Romashin (:romaxa)]

I think the same as on device. otherwise it is hard to debug X86/arm versions which have different DPI different rendering e.t.c.

Comment 4

[Oleg Romashin (:romaxa)]

Also I don't like approach with hardcoded DPI based on some values from /proc/....
I think it should not be inside GFX core.
I would like to have some preferences for DPI, themeing, fonts, which 3rd application can setup on their own...
And for default mozilla browsers create some platform component which will choose default preference set for specific platform in run-time.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Bug 518378 adds a check for a null lineStream which should fix this crash.

I'm open to other ways of doing this, instead of hard-coded values based on values from a text file. I mean, in the case of maemo, the dynamic determination of DPI would still be based on hard-coded values, but having this code in gfx core is not a great solution.

Open in new bug?