518572 - add-ons OK message when no networking availabe, yields never ending ok loops

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Joel Maher ( :jmaher ) (PTO: back Nov 2nd) (UTC -0700)]

on my n810, I turn off my internet connection and go to the add-ons manager.  I pan down to "Get Add-ons" and there is a message "Fennec couldn't retrieve add-ons" with and "ok" button.  I click ok, it does a search (<1 second time) and gives me back my same OK button.  Not a very good UX.

This is tested on my n810 with 20090924 1.9.2 nightly build.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

What UX were you expecting? What's so bad about the current behavior?

Comment 2

[Joel Maher ( :jmaher ) (PTO: back Nov 2nd) (UTC -0700)]

an OK button indicates you understand the error and are dismissing it.  It is just that this comes back an haunts you, it never really gets dismissed.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Should we use "Retry" instead of "Ok"?

Comment 4

[Martijn Wargers (zombie)]

I see the same issue with the "Cancel" button. When my internet is slow, it keeps trying to search for add-ons. So when I get tired of that, I click the "Cancel" button, but I can click as I want on that button, but the search for add-ons just goes on, which makes me think that "Cancel" button doesn't do anything.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Madhava - thoughts?

Comment 6

[Shyam Prasad Murarka]

Hi Matt,

I would like to work on this bug but I would require total guidance as this would be my first bug. :)

Also, I did not know how to send you this request (whether by mail or some other portal), that is why I am commenting it directly on this bug.

Thanks.

Comment 7

[Matt Brubeck (:mbrubeck)]

(In reply to Shyam Prasad Murarka from comment #6)
> I would like to work on this bug but I would require total guidance as this
> would be my first bug. :)

Okay.  The first steps are to build Fennec from source code and make sure you can reproduce this bug.  Then you can start looking at and changing code.  Instructions at:
https://wiki.mozilla.org/Mobile/Fennec

Here's some of the relevant code:
https://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/extensions.js#859

See Mark's suggestion in comment 3 for a simple change to make.

> Also, I did not know how to send you this request (whether by mail or some
> other portal), that is why I am commenting it directly on this bug.

You can comment in this bug for any questions or comments directly related to it.  If you have other questions (e.g. general questions about how Fennec works or getting it to build), please email me directly, find me on #mobile at irc.mozilla.org, or post in the newsgroup: https://groups.google.com/forum/#!forum/mozilla.dev.platforms.mobile

Good luck, and please don't hesitate to ask questions!

Comment 8

[Shyam Prasad Murarka]

Attachment: When no network is available in Addons, display "Retry" message instead of "OK"

Comment 9

[Matt Brubeck (:mbrubeck)]

Comment on attachment 559758 [details] [diff] [review]
When no network is available in Addons, display "Retry" message instead of "OK"

Hi, thanks for the patch!  Could you change just one thing, please?  We need to change the string ID so localizers will update their translations.  (You can just change it to "addonsSearchFail2.button" or something.)

Comment 10

[Shyam Prasad Murarka]

Attachment: When no network is available in Addons, display "Retry" message instead of "OK"

Comment 11

[Matt Brubeck (:mbrubeck)]

Comment on attachment 559764 [details] [diff] [review]
When no network is available in Addons, display "Retry" message instead of "OK"

Looks good!

> addonsSearchFail.button=OK
>+addonsSearchFail.retryButton=Retry

You can delete the old "OK" string here.  I changed this myself and then pushed your patch to inbound.  It will be merged to mozilla-central in included in nightly builds within a day or two:

http://hg.mozilla.org/integration/mozilla-inbound/rev/7b9267933bb4

Comment 12

[:ehsan akhgari]

http://hg.mozilla.org/mozilla-central/rev/7b9267933bb4

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

hey guys, this patch will be invisible for our localizers (they will not be able to see that the entity value changed).

Could you please assing a new entity ID for the entity that receives a value change?

Comment 14

[Matt Brubeck (:mbrubeck)]

(In reply to Zbigniew Braniecki [:gandalf] from comment #13)
> Could you please assing a new entity ID for the entity that receives a value
> change?

Unless I'm missing something, the patch *did* assign a new entity ID.

Comment 15

[Matt Brubeck (:mbrubeck)]

Note that the final patch as checked in is slightly different from either version attached to the bug (it merges both attachments and also fixes the nit from comment 11):
http://hg.mozilla.org/mozilla-central/rev/7b9267933bb4

Comment 16

[Catalin Suciu [:csuciu]]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1