518586 - Get Mail toolbar button not display "get all new messages" item after customising toolbar

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect, P2)

Description

[[:Aureliano Buendía]]

Usually "Get Mail" toolbar button, display n items:

---------------------
get all new messages |
---------------------
account 1            |
...                  |
account n            |
---------------------

But if I open the window for customize toolbar "get all new messages" disappair.

STR:
1. rx click on toolbar and select "custumize..."
2. on "customize toolbar" window click done button.

goto "Get Mail" toolbar button: "get all new messages" is ghost.

When restart TB, all is fine.

I cannot find any dupe.


Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090924 Lightning/1.0pre Shredder/3.0pre ID:20090924031806

Comment 1

[Ludovic Hirlimann [:Usul]]

It's dup that as just been fixed

Comment 3

[[:Aureliano Buendía]]

According to Mark Banner in bug #516353#c23, this bug is reopen.

Comment 4

[Mark Banner (:standard8)]

Clarifying title as it only happens *after* customising the toolbar.

Comment 5

[[:Aureliano Buendía]]

Confirmed also today in

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090930 Lightning/1.0pre Shredder/3.0pre ID:20090930031731

See STR in comment #0

It's a TB3 blocker?

Comment 6

[David Ascher (:davida)]

Should probably be fixed.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Attachment: Keep track of which children we added, and only remove those.

The only sane way I could figure out to fix this is to keep track of the children we've created, and only remove those on _teardown.

Thanks,
Blake.

Comment 8

[David :Bienvenu]

Comment on attachment 404841 [details] [diff] [review]
Keep track of which children we added, and only remove those.

I don't know if there's a better way to do this, but it looks OK.

Comment 9

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/a470766f312b