518725 - Lack of URL encoding when searching for add-ons with tags

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Search, defect, P2)

Description

[krupa raj[:krupa]]

steps to reproduce:
1.Add "!=" as a tag to any add-on(counterpixel)
2.Search for the name of that add-on
3.In the Search results page,click on the associated tag


observed behavior:
A blank page loads.500-Internal Server Error due to lack URL encoding

Comment 1

[krupa raj[:krupa]]

Internal server error on using mirroring character of unicode in tag

https://preview.addons.mozilla.org/en-US/firefox/search?q=wmlbrowser&appid=1&cat=0,0&tag=%28%E2%80%AE%E2%80%AE%28&atype=-1&pid=-1&lup=&sort=&lver=-1&pp=20

Comment 2

[krupa raj[:krupa]]

As per discussion with Dave Dash on IRC,moving this bug to 5.2

Comment 3

[krupa raj[:krupa]]

As per discussion with Wil Clouser on IRC,moving this bug back to 5.1

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Attachment: v1

urlencoded stuff, and validated tags in the search module better.

Comment 5

[Wil Clouser [:clouserw]]

Hmm.  There is a reason I didn't do this back in the day.  Perhaps it will come to me in a dream tonight.

Comment 6

[Wil Clouser [:clouserw]]

Comment on attachment 407172 [details] [diff] [review]
v1

Ah, because % is in invalid char when searching for tags (bug 503490).  With this patch I'm seeing fatal errors and stack traces with tags that aren't ascii (e.g. モジラ), and some that are, (anything with } or . in it).  

% problems aside, if you're going to use a regex for invalid chars, you should be using the existing INVALID_TAG_CHARS

Comment 7

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Attachment: v2

Using INVALID_something_something

Comment 8

[Wil Clouser [:clouserw]]

Comment on attachment 407373 [details] [diff] [review]
v2

I'll r+, please fix the grammar in "String does matches: "

I don't get a server error, but I don't get search results either.  Just "No results found."  Was the patch supposed to return correct results too?

Comment 9

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Did you reindex after you did the UTF-8 fixes?  For me to self-verify I tagged something in Japanese, reindexed, searched clicked on the tag and saw the result.

Comment 10

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Enjoy:

------------------------------------------------------------------------
r53893 | [e-mail] | 2009-10-21 14:18:48 -0700 (Wed, 21 Oct 2009) | 2 lin

[bug 518725] Fixed a grammar error

------------------------------------------------------------------------
r53892 | [e-mail] | 2009-10-21 14:18:45 -0700 (Wed, 21 Oct 2009) | 2 lin

[bug 518725] using IGNORE_TAG_CHARS

------------------------------------------------------------------------
r53891 | [e-mail] | 2009-10-21 14:18:42 -0700 (Wed, 21 Oct 2009) | 2 lin

[bug 518725] Urlencoding

Comment 11

[Wil Clouser [:clouserw]]

Aah, pesky reindexing.  I did not.

Comment 12

[krupa raj[:krupa]]

STR:
1.go to firebug add-on details page
2.Add "!=" as a tag
3.Wait for > 10 mins.(sufficient time for Cron to run)
4.Go to firebugadd-ons details page
5.Click on the "!=" tag.

expected results:
All add-ons associated with that tag are listed(firebug)

URL:https://preview.addons.mozilla.org/en-US/firefox/tag/!=

actual results:
No result found

screencast: http://screencast.com/t/5W2WhPc3

Comment 13

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Attachment: v3

The actual tag page should server results from sphinx, not the old Search component.

-d

Comment 14

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Take that Krupa!


r54890 | [e-mail] | 2009-11-02 16:22:11 -0800 (Mon, 02 Nov 2009) | 2 li

[bug 518725] Using sphixn to serve tags pages... like Delicious all overa gain

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

https://preview.addons.mozilla.org/en-US/firefox/tag/!= gives me two results, both of which have that tag, so it's looking good.  It's Krupa's bug, so she should have the honors (and, nice find!)

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.