All users were logged out of Bugzilla on October 13th, 2018

JSSLOT_ARRAY_COUNT is incorrect in array returned from Object.keys

RESOLVED FIXED

Status

()

--
minor
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey, URL)

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 402726 [details] [diff] [review]
Set the count when done

This should only matter for denseness considerations.  I think.  However, I'm not absolutely confident we always do that (it being a whole-system consideration), so to be safe we should do this even if we're not worried about Object.keys(O) arrays and their denseness over time.

I really wish we had some better way to track sparseness than tracking this count everywhere in such a fragile manner, also slowing down dense-array sets when we eventually make tracing those sets not involve function-call overhead, but I don't see anything obvious to do instead.  :-(
Attachment #402726 - Flags: review?(mrbkap)
Attachment #402726 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 1

9 years ago
http://hg.mozilla.org/tracemonkey/rev/4a35dd652448
Whiteboard: fixed-in-tracemonkey

Comment 2

9 years ago
http://hg.mozilla.org/mozilla-central/rev/4a35dd652448
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.