518737 - NJ merge: NativeSparc cleanup

Status: VERIFIED FIXED

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

Description

[Nicholas Nethercote [inactive]]

Attachment: patch

This patches merges various Sparc changes from TM:

- Added asm_align_code()... not certain about it, but it seems reasonable
  (esp. given that Sparc-on-Tamarin doesn't appear to be tested... see below).

- Removes some extraneous end-of-line whitespace.

- asm_call(): uses MAXARGS instead of 10, adds an assertion and some debug
  printing.

- nRegisterAllocFromSet(): makes the arg type match the Assembler.h declaration.

- asm_restore(): minor arg name change.

- asm_store64() and asm_quad(): updates some code that dates from back before
  LIR was widened(!)  Does anybody actually run Tamarin on Sparc?

- Add and use LDUH32 and related macros.

- Capitalize the 's' in '__nanojit_Nativesparc__' to match the filename.

- Remove MOVCSI, which is dead.

Compiles cleanly on x86, but I don't have access to a Sparc machine.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: patch v2

This version also converts some LIR_addp occurrences in asm_arith() to LIR_iaddp, because qaddp cannot be passed to asm_arith().

Comment 2

[Rick Reitmaier]

pushed https://bugzilla.mozilla.org/show_bug.cgi?id=518737

Comment 3

[Chris Peyer]

Resolved fixed engineering / work item that has been pushed.  Setting status to verified.