518863 - Thunderbird deletes session.json on exit if remove Global Search field from toolbar

Status: VERIFIED FIXED

(Thunderbird :: Search, defect)

Description

[Pete Riley]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 3.5.30729)
Build Identifier: TB 3.0 beta 4 / Lightning 1.0pre 2009-09-24 / WinXP

Thunderbird deletes session.json on exit if I remove the Global Search field from the toolbar.

Reproducible: Always

Steps to Reproduce:
1. Remove the Global Search field
2. Open more than one tab
3. Restart TB

Actual Results:  
Only the first tab appears.

Expected Results:  
All tabs that were open before the restart should appear.

I've also disabled "Tools > Options > Advanced > Global Search and Indexer".

I also use Lightning.  Normally I have Month View in tab #2 and no other tabs open.  However, I can reproduce it with only having mail tabs open when I restart.

Nothing in the error console, but the problem happens on exit so I don't know if any errors are thrown.

Comment 2

[Ludovic Hirlimann [:Usul]]

Pete is that issue also present if you launch TB in safe-mode ?

Comment 3

[Pete Riley]

> Pete is that issue also present if you launch TB in safe-mode ?
Well, no, but the Global Search is always enabled on the toolbar when I launch TB in safe mode, even if I remove it before a restart.

Comment 4

[Pete Riley]

Also, if I start TB in normal mode, disable all my extensions, remove Global Search from the toolbar, restart TB, open a message in tab 2, click on tab 1, click on Inbox, close TB, TB crashes.

Comment 5

[Ludovic Hirlimann [:Usul]]

(In reply to comment #4)
> Also, if I start TB in normal mode, disable all my extensions, remove Global
> Search from the toolbar, restart TB, open a message in tab 2, click on tab 1,
> click on Inbox, close TB, TB crashes.

Can you give is a crash ID for this ?

Comment 6

[Pete Riley]

Crash ID: bp-6f29c336-2736-4412-b963-f81402090928

Comment 7

[David Ascher (:davida)]

Attachment: one fix

The attached fix deals with an exception during the process of removing the search widget from the toolbar, but doesn't deal w/ the real issue.  Still, should get it in.

Comment 8

[David Ascher (:davida)]

Attachment: patch v1

This is the real fix (but the first patch is still valid).

Comment 9

[David :Bienvenu]

Comment on attachment 403647 [details] [diff] [review]
patch v1

together, these two patches make shutdown much happier. I'll land them.

Comment 10

[David :Bienvenu]

fix checked in.

Comment 11

[Pete Riley]

Ludovic, I'd like to test this but I'm confused about which nightly I should download:

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/

latest-comm-1.9.1-l10n
latest-comm-1.9.1
latest-comm-central-l10n
latest-comm-central-trunk

I live in the U.S.

Comment 12

[Ludovic Hirlimann [:Usul]]

> latest-comm-1.9.1
is the one you want. If it works - please mark the bug verified.

Comment 13

[Pete Riley]

This is fixed on my pc.  Thanks for your assistance.