518882 - Download Manager: Need a Remove button for canceled entries

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20090925 Fennec/1.0a3

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.2b1pre) Gecko/20090925
Fennec/1.0b4pre

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20090925
Fennec/1.0b4pre

and

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090925 Fennec/1.0a3

Steps to Reproduce:
1. Begin a download from the nightly builds page (something that'll take longer than 2 minutes to download)
2. Go to the download manager
3. Cancel the download

Actual Results:
The retry button is the only one available, but there should be a way (just like with finished downloads) to remove the entry from the download manager completely.

Expected Results:
There's a "Remove" button on the entry.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/15b680c19ddf

added the "show-on-select" class to the remove button

Comment 3

[Aakash Desai [:aakashd]]

verified FIXED On builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.2b1pre) Gecko/20091022 Fennec/1.0a4pre

and

Mozilla/5.0 (X11; U; Linux armv7l; en-US; rv:1.9.2b1pre) Gecko/20091022
Fennec/1.0b5pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20091022
Fennec/1.0b5pre

Comment 4

[Aakash Desai [:aakashd]]

litmus testcase 9800 has been created to regression test this bug.