518892 - Changing any general settings disables minify on production

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[James Socol [:jsocol, :james]]

STR on a local copy of SUMO:
1. Make sure minify is enabled.
2. chmod 555 webroot/files/minify.conf <- must not be writable by the server
3. go to tiki-admin.php?page=general
4. save the settings

Result:
Minify has been disabled. Error while opening: files/minify.conf

Expected result:
Minify is only disabled if it fails writing while changing something. If nothing changes, it shouldn't even attempt to write to its conf file.

I think this is related to the minify issues we have during pushes. On prod, the server can't write to its minify.conf, so any attempt to change general prefs will disable minify.

Comment 1

[James Socol [:jsocol, :james]]

Attachment: patch, v1

This will prevent tiki-admin_include_general.php from attempting to write to minify.conf if the setting hasn't changed (for example, if you're changing something else in the general options).

That will stop the fallback mechanism from disabling minify in the database.

Comment 2

[James Socol [:jsocol, :james]]

r52466 / r52467 / r52468

Comment 3

[James Socol [:jsocol, :james]]

Assigning to me for historical accuracy.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; James walked me through this (changed a setting on staging), and we verified that Minify is still active (no error message).

Comment 5

[Louis-Philippe Huberdeau]

Only applicable to SUMO as it's related to the minify implementation.

As for the type of problem, there is a solution to this with 4.0 called "lesser magic" for better preference management.