519010 - Add preview icon to the Personas menu

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Personas Plus, enhancement)

Description

[Kohei Yoshino]

Attachment: concept patch

It would be nice if the Personas menu items have each preview icon. We can choose a persona by color at a glance, even if we cannot understand those labels (especially for non-native English speakers.)

Comment 1

[Kohei Yoshino]

Attachment: screenshot with the patch applied

Comment 2

[Kohei Yoshino]

The problems are:

* A check mark for the selected persona disappeared.
* The size of preview_popular.jpg is 64px × 40px. 16px × 16px icons should be generated server-side.

Comment 3

[Chris Beard]

looks great kohei, interesting enough i had just been playing around with a similar patch.  

> * The size of preview_popular.jpg is 64px × 40px. 16px × 16px icons should be
> generated server-side.

making the menu more visual was one of the reasons for starting to incorporate icons into the feed.  agreed, that we should work on optimization.  another thing to consider would be to incorporate data URLs with the 16x16 images into the JSON data feed.

> * A check mark for the selected persona disappeared.

i'm not convinced that the check mark is necessary. originally i was thinking that it would be helpful in letting users know which persona they had selected, but subsequently we added the status display at the root of the menu, and in practice if we add the icon it should be obvious.  i'm also looking at changing the visual style of the menu and it's possible that we could do something like use a background colour instead.

Comment 4

[Kohei Yoshino]

The feature has been introduced in Personas 1.4. I just filed Bug 530733 about the JSON format compatibility.