519051 - [faceted search] sidebar don't go all the way down if few searches found

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Andreas Nilsson (:andreasn)]

Attachment: patch to fix the issue

If only one or two searches is found, the sidebar don't go all the way to the bottom of the page.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

This cleans up the layout for our empty and busy pages so marking as such.  Also means this inherits blocking+

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 403041 [details] [diff] [review]
patch to fix the issue

david can you take a look at this?  The only thing I'm slight unsure about is the min-height: 100%; I didn't think that would do anything over a height: 100%;

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 403041 [details] [diff] [review]
patch to fix the issue

this looks right and from some limited testing is working well for me.  With 1,2,4,6,20 result sets the sidebar is always full height.

Comment 4

[Andreas Nilsson (:andreasn)]

(In reply to comment #2)
> (From update of attachment 403041 [details] [diff] [review])
> david can you take a look at this?  The only thing I'm slight unsure about is
> the min-height: 100%; I didn't think that would do anything over a height:
> 100%;

The min-height part is what I've picked up should work when searching for this (like http://th1rty7.blogspot.com/2008/02/100-height-div-in-firefox.html), but I'll test if it works with just height: 100%; (or perhaps height: auto; ?)

Comment 5

[David Ascher (:davida)]

Comment on attachment 403041 [details] [diff] [review]
patch to fix the issue

both min-height and height seem to work for me on mac.

Comment 6

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/87f28c60f29d