519107 - SVGElement::isSupported is not supported

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Takeshi Kurosawa :takenspc]

Attachment: Patch

svgElement.isSupported(feature, version) is not yet implemented. We should implement it.

Comment 1

[Takeshi Kurosawa :takenspc]

Attachment: Testcase

Comment 2

[Robert Longson [:longsonr]]

http://www.w3.org/TR/DOM-Level-3-Core/core.html#Level-2-Core-Node-supports says This is the same name which can be passed to the method hasFeature on DOMImplementation.

http://www.w3.org/TR/SVG/svgdom.html#FeatureStrings eventually leads to this set of feature strings... http://www.w3.org/TR/SVG/feature.html one of which you have in your testcase.

nsGenericElement::InternalIsSupported certainly includes this via nsSVGFeatures::HaveFeature but it also includes much more. I must admit I'm not sure whether it is right to include things not listed in nsSVGFeatures::HaveFeature or not.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

What do other browsers do?

Can you get clarification from www-svg?

Can we have a mochitest here? I guess somewhere we have tests for hasFeature with a list of test strings, can we just run all those tests on different kinds of elements as well?

Comment 4

[Takeshi Kurosawa :takenspc]

Attachment: More testcase

(In reply to comment #3)
> What do other browsers do?

Opera 10, Safari 4 and Chrome 3 support checking SVG feature strings and 'HTML', 'HTMLEvents', etc... for SVG elements

# BTW, They (and Gecko) return |true| for SVG feature strings for HTML elements
# http://taken.s101.xrea.com/tmp/isSupported.html

Comment 5

[Robert Longson [:longsonr]]

Can you produce a mochitest please?

Comment 6

[Takeshi Kurosawa :takenspc]

Attachment: mochitest

Simple test determinants whether isSupported is available for SVGSVGElement.
# Should I add a comment to nsSVGFeaturesList.h?

Comment 7

[Robert Longson [:longsonr]]

Comment on attachment 403500 [details] [diff] [review]
mochitest

>+
>+function testIsSupported(elem) {
>+  for each (var [feature, version, excepted_result] in featurs) {

I think the right semantics would be to call the variable accepted_result and the array should be called features

>+    if (excepted_result) {
>+      ok(elem.isSupported(feature, version), "isSupported(" + feature + ", " + version + ") returned wrong value, Was it chnaged to unsupported feature?");

"changed to an unupported feature" rather than "chnaged to..."

>+    } else {
>+      todo(elem.isSupported(feature, version), "isSupported(" + feature + ", " + version + ") is unsupported feature string");
>+    }

Should probably include some non-SVG specific tests too i.e. HTML, HTML events etc.

Comment 8

[Takeshi Kurosawa :takenspc]

Attachment: mochitest (comment addressed)

Comment 9

[Robert Longson [:longsonr]]

pushed http://hg.mozilla.org/mozilla-central/rev/cc3c732f56cd

Comment 10

[Robert Longson [:longsonr]]

pushed http://hg.mozilla.org/mozilla-central/rev/1b3409557b31