Closed Bug 519145 Opened 15 years ago Closed 15 years ago

Enumeration over XPCNativeWrapper is broken

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mrbkap, Assigned: mrbkap)

Details

Attachments

(1 file)

jjb reported this in mozilla.dev.platform:

> .. for (var p in rect) fails, it's a funky interface thing, not a an object.

This is because XPCWrapper::Enumerate doesn't walk down the prototype chain. This is a regression from bug 390947.
Attached patch FixSplinter Review
The only really tricky bit is setting up the temporary XPCNativeWrapper.
Attachment #403164 - Flags: review?(jst)
Comment on attachment 403164 [details] [diff] [review]
Fix

In your own words, you should also test that enumeration of expandos on the wrapper itself works as well.

r=jst with that.
Attachment #403164 - Flags: review?(jst) → review+
http://hg.mozilla.org/mozilla-central/rev/26a9e4b405a0
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: