519192 - Fix up context menu for gloda search results list tab - can't move, copy, tag, mark messages etc

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Mark Banner (:standard8)]

Spun off from bug 515770:

(In reply to comment #5)
> "Open as list" does the trick for search lists, but does not provide the
> following right-click actions:
> 
> - Move message to
> - Copy message to
> - Move again to <last move made>
> - Delete
> - Label (and submenu)
> - Mark (and submenu)

This is an error in (after the part 1 patch on bug 519041) nsContextMenu.js - it assumes that we have a folder available to check if we can move messages or not.

I'm not sure of the exact solution for this yet but I'll take it on soon after bug 519041.

As this is all sharing the "mailContext" menu, it doesn't affect strings.

Comment 2

[Ludovic Hirlimann [:Usul]]

xref bug 515770

Comment 3

[Mark Banner (:standard8)]

Attachment: The fix

This provides the capabilities to move/copy/mark/tag/create filter from messages in the global view as list view using the main message menu or the context menu.

Info:

- Added a new function to FolderDisplayWidget called canDeleteSelectedMessages; this lets us determine if we can delete messages in a folder (i.e. typically non-news) and can be used from more than one place.

- create from filter options adjusted to use the folder/server info from the selected message header rather than the displayed folder (as gloda view as list doesn't have a folder).

- Main message menu and context menu items similarly adjusted to look at the details of the folders etc on the selected message headers rather than the display folder.

- I used MessageDisplayWidget.isDummy in a couple of places to detect an .eml file loaded in a standalone message window.

- One hack applied for moving messages (the do copy rather than move option comes into play for the "File" toolbar button); the current detection is for if the folder URI is a news URI. This is actually incorrect for saved searches (which could be cross non-news and news), but also gloda view as list doesn't have a folder hence no URI. As gloda doesn't currently index newsgroup messages, I've based the current determination on whether or not the folder exists and then if its a news URI.

Tested context & message menus in standalone message window, tabs, 3-pane message, global view as list view and they seem to be working fine now.

Comment 4

[David :Bienvenu]

Comment on attachment 408232 [details] [diff] [review]
The fix

I had some problems with messages where the server was using the imap delete model, but I suspect those problems also exist without this patch. The core view code is assuming a standard imap delete model across the whole view, which isn't true for gloda search results (or cross-folder search results in general)

Comment 5

[Mark Banner (:standard8)]

Checked in:

http://hg.mozilla.org/comm-central/rev/c152b9776a19
http://hg.mozilla.org/releases/comm-1.9.1/rev/9a9bfc52ff86