Closed Bug 519231 Opened 15 years ago Closed 15 years ago

Backing out bug 514623 and bug 501566

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
fennec1.0b4

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(2 files, 1 obsolete file)

patch (514623)
8.16 KB, patch
stechz
: review+
Details | Diff | Splinter Review
patch 2 (501566)
3.38 KB, patch
stechz
: review+
Details | Diff | Splinter Review 
Due to performance issues we are backing out bug 514623 and bug 501566. Since there has been several patches landed on top of them, I am posting the patches for review.

Original checkins:
http://hg.mozilla.org/mobile-browser/rev/66ba098af8ac (bug 514623)
http://hg.mozilla.org/mobile-browser/rev/4b520153dd86 (bug 501566)
Attached patch patch (514623) — — Splinter Review 
Assignee: nobody → mark.finkle

        Attachment #403262 -
        Flags: review?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch (501566) (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #403263 -
        Flags: review?

    
    

    
  
Not quite right yet. Silly bug fix coming up.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch 2 (501566)
        — 
          — Splinter Review
      

    


  
Last patch had a bug

        Attachment #403263 -
        Attachment is obsolete: true

        Attachment #403269 -
        Flags: review?(webapps)

        Attachment #403263 -
        Flags: review?

        Attachment #403262 -
        Flags: review? → review?(webapps)

    
    

    
  
Comment on attachment 403262 [details] [diff] [review]
patch (514623)

Looks good.

        Attachment #403262 -
        Flags: review?(webapps) → review+

    
    

    
  
Comment on attachment 403269 [details] [diff] [review]
patch 2 (501566)

Good except one nit: either remove mouseDown and mouseUp in browser.js or leave the clicker calls in InputHandler.js.

        Attachment #403269 -
        Flags: review?(webapps) → review+

    
    

    
  
pushed:
https://hg.mozilla.org/mobile-browser/rev/2d17707323ef
https://hg.mozilla.org/mobile-browser/rev/720b4cbda47e
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → B4

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: