Closed Bug 519235 Opened 12 years ago Closed 12 years ago

Fix jsctypes unsigned __int64 conversion on windows

Categories

(Core :: js-ctypes, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: dwitte, Assigned: dwitte)

Details

Attachments

(1 file)

See bug 513783 comment 54 and bug 513783 comment 55. We can specialize the templated jsvalToIntStrict() function for unsigned __int64 on windows.
Hardware: x86_64 → x86
Attached patch v1Splinter Review
Passes tests on tryserver. (The source I quoted in bug 513783 comment 55 claimed that MSVC also throws a compile error and/or has runtime issues converting unsigned __int64 to double, but I'm happily surprised that it doesn't, otherwise the same unit test should have failed.)
Assignee: nobody → dwitte
Attachment #403410 - Flags: review?(jorendorff)
Comment on attachment 403410 [details] [diff] [review]
v1

Amazing.
Attachment #403410 - Flags: review?(jorendorff) → review+
Attachment #403410 - Flags: approval1.9.2?
Product: Other Applications → Core
Version: Trunk → unspecified
http://hg.mozilla.org/mozilla-central/rev/1d1373e850f0
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #403410 - Flags: approval1.9.2? → approval1.9.2+
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.