519296 - openPopup with "after_pointer" doesn't work

Status: RESOLVED FIXED

(Core :: XUL, defect, P2)

Description

[Kazuho Okui]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
Build Identifier: 

tooltip/menupopup openPopup function with "after_pointer" doesn't work if the element is on xul:panel.

Reproducible: Always

Steps to Reproduce:
1. Create xul:panel and xul:tooltip
2. Put some element on the panel
3. open tooltip with tooltip.openPanel(target, "after_pointer", 0, 0, false, false)
Actual Results:  
tooltip won't appear, or appear wrong place.

Expected Results:  
tooltip should appear near by mouse cursor.

Attached XUL file can reproduce this bug.

Comment 1

[Kazuho Okui]

Attachment: the code that reproduce this bug

Comment 2

[Markus Stange [:mstange]]

What does "tooltip won't appear, or appear wrong place" mean? In which cases does it not appear at all? And when it appears "in the wrong place", where exactly does it appear?

When I click the button in your testcase, the popup opens with its top left corner exactly under the cursors "click position". Does that not work for you?

Comment 3

[Kazuho Okui]

Oops, I didn't mention that this bug appears on latest Firefox trunk, works fine with 3.0/3.5. Not sure on 3.6beta.

Comment 4

[Markus Stange [:mstange]]

I'm testing with today's trunk nightly and I don't see what you're seeing (or I don't understand it).

Comment 5

[Kazuho Okui]

Did you click "Search" Button on the panel? Pls try to click "Panel" then click "Search" button. On Fx 3.5, click search button opens tooltip after mouse cursor, but on Trunk, tooptip won't appear.

I tested this on http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/

firefox-3.7a1pre.en-US.mac.dmg	28-Sep-2009 06:28 	 23M

Not tested on Win/Linux.

Comment 6

[Markus Stange [:mstange]]

Aha, the search button! You could have said that in your STR ;)
OK, I see what you mean.

Comment 7

[Markus Stange [:mstange]]

Yeah, I could have read the code more thoroughly, but somehow I didn't see it...

Comment 8

[Kazuho Okui]

Sorry about not explain it clearly..

Comment 9

[Ria Klaassen (not reading all bugmail)]

I can reproduce the described behavior on Windows Vista.

Regression range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7b8ca8c944f2&tochange=e45938aee309

Bug 279539 seems a possible cause. Please remove if the dependency is not correct.

Comment 10

[Neil Deakin]

Attachment: fix

after_pointer has never really worked as it should, and the value should probably just be removed. This patch should fix the regression though.

Comment 11

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/fe0b21c887a5

Comment 12

[Kazuho Okui]

Is this fixed? I downloaded latest Firefox trunk, but it seems bug is still in there.

test in:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/
firefox-3.7a1pre.en-US.mac.dmg	06-Oct-2009 04:33 	 23M

Comment 13

[Drew Willcoxon :adw]

Can we get this on 1.9.2?  Jetpack's menu impl (bug 494651) allows popups on arbitrary nodes in content via nsIPopupBoxObject.openPopup, and after_pointer is the best position for that.  It's not a must since other positions are passable, but it would be nice.

Comment 14

[Drew Willcoxon :adw]

Comment on attachment 404064 [details] [diff] [review]
fix

See previous comment.

Comment 15

[Neil Deakin]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/df76f7d754b5

Comment 16

[Kazuho Okui]

This still bugs to me on Mac. Please check an attached screen shot. I open tooltip like following:


tooltip.openPopup(target, "after_pointer", 16, 8, false, false);

"before_end", or the other method works fine and this happens only on Mac, not happens on Windows.

Comment 17

[Kazuho Okui]

Attachment: openPopup with "after_pointer" opens huge popup

Comment 18

[Neil Deakin]

Please attach a testcase showing what you think is wrong.

Comment 19

[Kazuho Okui]

Attached xpi file will reproduce the bug.

on Mac:

Popup open wrong place. If you modify overlay.js Line:5 to 'before_end' or something else, it works.

on Windows:

It works appropriately.

Comment 20

[Kazuho Okui]

Attachment: Code that reproduce after_pointer bug

Comment 21

[Kazuho Okui]

P.S. I tested this on Firefox 3.5.4 and 3.6b1 for Mac & Windows. Only Firefox 3.6b1 on Mac couldn't handle this.

Comment 22

[Neil Deakin]

Don't see any problem with this, either on Mac on Windows. The panel appears in the right place. If you can make a simple testcase (just one file, not an extension) which shows an issue, please file a new bug.

Comment 23

[Kazuho Okui]

Create a XUL file and new bug: https://bugzilla.mozilla.org/show_bug.cgi?id=526610

Comment 24

[Neil Deakin]

Wait, you're testing on 3.6b1? Or a nightly build? The patch only went into 3.6 last week, so if you're using a build earlier than that, you won't see the fix.

Comment 25

[Kazuho Okui]

Grr, yes, I tested on 3.6b1. Downlaoded 3.6b2pre and confirmed that the bug is fixed. Thanks!

Comment 26

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Neil, is it expected that the tooltip of the testcase doesn't close when you close the opened panel just by clicking in the white area? It even stays on top when I switch to other applications. Tested with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b2pre) Gecko/20091104 Namoroka/3.6b2pre ID:20091104033600

Comment 27

[Neil Deakin]

The 'tooltip' should not close as the testcase never closes it. Note that, despite using the <tooltip> tag, it isn't being opened as a tooltip, so the normal tooltip event handling isn't occurring.

Comment 28

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ah ok, so comparing the behavior in Namoroka with Shiretoko shows me that we have a vertical offset to the search button now. While in Shiretoko the popup is opened directly beneath the button it's now shifted down by around 20px.