i always see this warning while compiling with mc mozilla/storage/Variant.h(152) : warning C4244: '=' : conversion from 'PRInt64' to 'PRInt32', possible loss of data it should just need a cast, but it's annoying
That's kinda annoying since I'm doing the bounds checking. If we change that line to |*_result = PRInt32(aValue);| does the error go away? http://mxr.mozilla.org/mozilla-central/source/storage/src/Variant.h#143
I don't know why gcc let you get away with that. static_cast is the way to go I think.
Created attachment 405079 [details] [diff] [review] patch v1.0
Comment on attachment 405079 [details] [diff] [review] patch v1.0 r=sdwilsh