Closed Bug 519460 Opened 15 years ago Closed 15 years ago

[Collector Extension] Settings issues in TB2

Categories

(addons.mozilla.org Graveyard :: Collector Extension, defect, P1)

x86
All
defect

Tracking

(Not tracked)

RESOLVED FIXED
BW-1.1

People

(Reporter: kinger, Assigned: kinger)

References

Details

Some things I notice initially:

- Large icon on right on Windows (see attached)
- too much empty space on Windows
- custom update frequency per collection pref does not stick (might be a general bug)
- In 'Manage Subscriptions' panel, items in list do not get focus styling. This is also a problem in the Subscriptions panel in Add-ons window.
- Auto-publishing stalls

Only error I see in console is:

Error: Bandwagon.Controller.Settings.elemBandwagonCollections.selectItem is not a function
Source File: chrome://bandwagon/content/ui/settingsController.js
Line: 132
Status: NEW → ASSIGNED
(In reply to comment #0)
> - Large icon on right on Windows (see attached)
> - too much empty space on Windows

Fixed, r52618.
Inclusion of some stylesheets needed to be extracted to chrome.manifest so that mail would not include the browser stylesheet and vice versa.

> - custom update frequency per collection pref does not stick (might be a
> general bug)

Not a general bug, works in Firefox.

> Only error I see in console is:
> 
> Error: Bandwagon.Controller.Settings.elemBandwagonCollections.selectItem is not
> a function
> Source File: chrome://bandwagon/content/ui/settingsController.js
> Line: 132

Also fixed in r52618. richlistbox.selectItem does not exist in Moz 1.8, the alternative that works on all builds is richlistbox.selectedItem = foo.
Auto publishing is working now. I think the failure before was a more general bug that I will file if I see it again.

The only functionality issue left in this bug is - custom update frequency per collection pref does not stick.
(In reply to comment #2)
> The only functionality issue left in this bug is - custom update frequency per
> collection pref does not stick.

Fixed, r52999. textbox.valueNumber does not workin TB2. Note also that textbox type=number does not show the up/down arrows on that platform.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Component: Collections → Collector Extension
QA Contact: collections → collector-extension
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.