Closed Bug 519465 Opened 13 years ago Closed 13 years ago

jsctypes broken on OSX 10.4/gcc-4.0.1/i686

Categories

(Core :: js-ctypes, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: dwitte, Assigned: dwitte)

Details

Attachments

(1 file)

Attached patch fixSplinter Review
Found by honzab:

i686-apple-darwin8-gcc-4.0.1 (GCC) 4.0.1 (Apple Computer, Inc. build 5370), Mac OS 10.4.11, XCode 2.5

/Users/starapica/Documents/mozilla/mozilla-1.9.2/out/js/ctypes/Function.cpp: In member function 'bool mozilla::ctypes::Function::Execute(JSContext*, PRUint32, jsval*, jsval*)':
/Users/starapica/Documents/mozilla/mozilla-1.9.2/out/js/ctypes/Function.cpp:566: error: invalid conversion from 'void (*)(...)' to 'void (*)()'
/Users/starapica/Documents/mozilla/mozilla-1.9.2/out/js/ctypes/Function.cpp:566: error:   initializing argument 2 of 'void ffi_call(ffi_cif*, void (*)(), void*, void**)'
Attachment #403497 - Flags: review?(benjamin)
Attachment #403497 - Flags: approval1.9.2?
honzab says the patch builds and passes tests.
It builds and test passes:

TEST-PASS | /Users/starapica/Documents/mozilla/mozilla-1.9.2/out/_obj-browser-test/_tests/xpcshell/jsctypes-test/unit/test_jsctypes.js | test passed
INFO | Result summary:
INFO | Passed: 1
INFO | Failed: 0
Attachment #403497 - Flags: review?(benjamin)
Attachment #403497 - Flags: review+
Attachment #403497 - Flags: approval1.9.2?
Attachment #403497 - Flags: approval1.9.2+
Product: Other Applications → Core
Version: Trunk → unspecified
http://hg.mozilla.org/mozilla-central/rev/b638150de7fb
Assignee: nobody → dwitte
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.