Closed Bug 519535 Opened 12 years ago Closed 12 years ago

NJ merge: add VTUNE dead code

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: graydon, Assigned: graydon)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

TR has some code related to a VTUNE interface that has bitrotted. They will be reviving it post-merge. Meanwhile we need to pick it up. It's disabled in our build and is, aside from aesthetic concerns, harmless dead code for us.
Attachment #403587 - Flags: review?(gal)
Blocks: 519561
Attachment #403587 - Flags: review?(gal) → review+
Comment on attachment 403587 [details] [diff] [review]
pick up the TR code

Ok, this is not well abstracted. If you guys really want to take the cruft first and then make it pretty, ok, but this nees to be abstracted and we need a proper interface and no include CodegenLIR.h.
once its revived it will be clean
(In reply to comment #1)
> (From update of attachment 403587 [details] [diff] [review])
> Ok, this is not well abstracted. If you guys really want to take the cruft
> first and then make it pretty, ok, but this nees to be abstracted and we need a
> proper interface and no include CodegenLIR.h.

It's not at all abstracted, I know. But we're down to < 100 lines of non-ARM delta and everyone on the team wants this merging hobby to cease. It's dead code and resolves a bunch of hunks, so we take it. It'll be fixed later. Promise.
http://hg.mozilla.org/tracemonkey/rev/0c933cb67ef7
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/0c933cb67ef7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.