|
3.61 KB,
patch
|
Edwin Smith
:
superreview+
|
Details | Diff | Splinter Review |
Created attachment 403609 [details] [diff] [review] import TM changes This patch pulls in some reset-simplification and asserts from TM's assembler. Applies to TR after ... several of the existing changes (best to land bug 519535 and its dependencies first). It doesn't logically depend on them, I don't think, but might not apply without.
|
(Assignee) | |
Comment 1•8 years ago
|
||
Created attachment 405110 [details] [diff] [review] assm reset changes Pure speculation, but might it be worthwhile to also call reset() in endAssembly() otherwise we'll have some variables laying about that are non-null, potentially gumming up the gc.
|
||
Updated•8 years ago
|
||
|
|
||
Comment 2•8 years ago
|
||
Comment on attachment 405110 [details] [diff] [review] assm reset changes Assembler is short-lived and stack allocated in Tamarin, so I don't see any reason to do any more cleanup work than necessary unless we have a legitimate GC bug or performance problem.
|
|
(Assignee) | |
Comment 3•8 years ago
|
||
pushed http://hg.mozilla.org/tamarin-redux/rev/235ba0da57e9
|
||
Comment 4•8 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Description
•