Closed
Bug 519561
Opened 16 years ago
Closed 16 years ago
NJ merge: combine the different assembler-reset methods
Categories
(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)
Tamarin Graveyard
Baseline JIT (CodegenLIR)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: graydon, Assigned: rreitmai)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.61 KB,
patch
|
edwsmith
:
superreview+
|
Details | Diff | Splinter Review |
This patch pulls in some reset-simplification and asserts from TM's assembler. Applies to TR after ... several of the existing changes (best to land bug 519535 and its dependencies first). It doesn't logically depend on them, I don't think, but might not apply without.
|
Assignee | |
Comment 1•16 years ago
|
||
Pure speculation, but might it be worthwhile to also call reset() in endAssembly() otherwise we'll have some variables laying about that are non-null, potentially gumming up the gc.
Attachment #403609 -
Attachment is obsolete: true
Attachment #405110 -
Flags: superreview?(edwsmith)
|
||
Updated•16 years ago
|
Attachment #405110 -
Flags: superreview?(edwsmith) → superreview+
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 405110 [details] [diff] [review]
assm reset changes
Assembler is short-lived and stack allocated in Tamarin, so I don't see any reason to do any more cleanup work than necessary unless we have a legitimate GC bug or performance problem.
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Comment 4•16 years ago
|
||
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•