Closed Bug 519565 Opened 15 years ago Closed 15 years ago

WriteBarrierRC::Clear() is wrong

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P2)

Product:
Tamarin Graveyard
Component:
Garbage Collection (mmGC)
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
flash10.1

People

(Reporter: stejohns, Assigned: lhansen)

Details

code is 

  REALLY_INLINE void Clear() { t = 0; }

but needs to DecrementRef on existing value, if any.
Assignee: nobody → lhansen
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → flash10.1
Actually what it needs is documentation; the method is correct.

It is used not at all in the VM and one place in the Flash Player, and there is a comment at that site of use to the effect that the referenced object has already been deleted and that it's important to clear out the smart pointer without touching the now-dead object.  So Clear() does the right thing.

I will add a comment to that effect and just push it.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Pushed to redux?
(In reply to comment #2)
> Pushed to redux?

Yes, just checked the code.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.