519573 - Notifications of anonymous-user followups in forum posts have "" as sender/attribution

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

STR:

1. While logged in, load http://support-stage.mozilla.org/en-US/forum/1
2. Click on "Ask a New Question"
3. Go through all four pages and check "Email me when my question has updates"
4. Click on "View Your Support Question" (or whatever it's called)
5. Log out
6. As an anonymous user, follow-up with a post

Actual:

"" has posted a reply to a thread you're watching.
You can view the thread and reply at the following URL:

https://support-stage.mozilla.org/en-US/forum/1/en-US/1/446895#threadId446896

Expected:

Something that indicates the user was anonymous

Comment 1

[Paul Craciunoiu [:paulc]]

Attachment: v1

This should do it.

Comment 2

[James Socol [:jsocol, :james]]

Comment on attachment 404701 [details] [diff] [review]
v1

To clarify the STR: make sure when you post anonymously to leave the name field blank. With this patch I still saw:

"" has posted a reply to a thread you're watching. 
You can view the thread and reply at the following URL:

Comment 3

[Paul Craciunoiu [:paulc]]

Okay. Did not account for that case, I admit! What should the default be if nothing is supplied? "An anonymous user", "A Firefox user"?

Comment 4

[James Socol [:jsocol, :james]]

In any other case it seems to work without the patch--Stephen can you confirm that?--so I think only the empty case is important. "An anonymous user" works for me.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #4)
> In any other case it seems to work without the patch--Stephen can you confirm
> that?--so I think only the empty case is important. "An anonymous user" works
> for me.

Yeah, this is only when you leave the name field blank.

Comment 6

[Paul Craciunoiu [:paulc]]

Attachment: v2

With this patch, if author is empty, it defaults to "An anonymous user"
Note that, because this is in the template, we can make it product-specific.

Comment 7

[James Socol [:jsocol, :james]]

Comment on attachment 407581 [details] [diff] [review]
v2

It works for me with only the template change. Why the change to tiki-ask_a_question.php?

Comment 8

[Paul Craciunoiu [:paulc]]

(In reply to comment #7)
> It works for me with only the template change. Why the change to
> tiki-ask_a_question.php?
Oh, does it work for anonymous users when they specify the name? Looking at the code it seemed like it shouldn't be working - hence, the change.

Comment 9

[James Socol [:jsocol, :james]]

Yep, see comments 4 and 5.

Comment 10

[Paul Craciunoiu [:paulc]]

Attachment: v3

No more change to tiki-ask_a_question.php

Comment 11

[James Socol [:jsocol, :james]]

Comment on attachment 407811 [details] [diff] [review]
v3

This is exactly what I tested locally. (Sorry, I meant to r+ this on Friday but I guess I didn't hit submit.)

Comment 12

[Paul Craciunoiu [:paulc]]

r54485 (trunk)

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED:

Date: Wed, 28 Oct 2009 13:33:22 -0700
To: [e-mail]
Subject: Reply notification: test
MIME-Version: 1.0
From: [e-mail]
Reply-To: <[e-mail]>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-ID: <[e-mail]>

An anonymous user has posted a reply to a thread you're watching. 
You can view the thread and reply at the following URL: 

https://support-stage.mozilla.org/en-US/forum/1/446895#threadId447027

Comment 14

[Paul Craciunoiu [:paulc]]

Awesome. Wow that's fast!

Comment 15

[Paul Craciunoiu [:paulc]]

r54623 (prod)