"Occurs before" search field should use a date picker widget

VERIFIED FIXED in 1.7.6

Status

--
enhancement
VERIFIED FIXED
9 years ago
7 years ago

People

(Reporter: jrmuizel, Assigned: ryansnyder)

Tracking

Trunk
1.7.6

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
It's not clear what format the input to "Occurs before" should be in. A date picker widget would help a lot here.
Assignee: nobody → ryan
Severity: normal → enhancement
Target Milestone: --- → 1.8
Created attachment 453261 [details] [diff] [review]
Patch 1 for 519610

Since the time that this ticket was created, we've changed the format of the input field from "MM/DD/YYYY" to "MM/DD/YY HH:MM:SS".

There are 2 options:  We can separate this field into 2 fields, a date field and a time field, and use a date picker for the date field.  Or we can keep these values in the same field and provide a tooltip that shows how to format the data in this field.

I chose the latter because it took up less space on the page and seemed to be the better solution for the UI.
Attachment #453261 - Flags: review?(ozten.bugs)
Attachment #453261 - Flags: feedback?(laura)

Updated

8 years ago
Attachment #453261 - Flags: feedback?(laura) → feedback+
Thanks Laura.  Committing.  Will be available on stage for testing in 15 minutes at http://crash-stats.stage.mozilla.com/query

==

Sending        webapp-php/application/views/common/query_form.php
Sending        webapp-php/application/views/layout.php
Sending        webapp-php/application/views/query/query.php
Adding         webapp-php/css/jquery.tooltip.css
Adding         webapp-php/js/jquery/plugins/jquery.dimensions.min.js
Adding         webapp-php/js/jquery/plugins/jquery.tooltip.min.js
Sending        webapp-php/js/socorro/query.js
Transmitting file data .......
Committed revision 2176.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

8 years ago
Attachment #453261 - Flags: review?(ozten.bugs)
Verified FIXED on http://crash-stats.stage.mozilla.com/query.
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: x86 → All

Comment 4

8 years ago
Merge to 1.7.6
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Target Milestone: 1.8 → 1.7.6
Committing for 1.7.6.

==

Sending        webapp-php/application/views/layout.php
Sending        webapp-php/application/views/query/query.php
Adding         webapp-php/css/jquery.tooltip.css
Adding         webapp-php/js/jquery/plugins/jquery.dimensions.min.js
Adding         webapp-php/js/jquery/plugins/jquery.tooltip.min.js
Sending        webapp-php/js/socorro/query.js
Transmitting file data ......
Committed revision 2745.
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
I think something's missing, or amiss with the build script?

15:59:00.094: Exception: $(".date-pick").datePicker is not a function Source File: http://crash-stats.stage.mozilla.com/js/socorro/query.js Line: 45, Column: 0 Category: content javascript
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This should fix it.  Let me know if it does not.  Thanks Stephen!

==

Sending        webapp-php/application/views/query/query.php
Transmitting file data .
Committed revision 2748.
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Sorry -- still not working, and now, no JS errors.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 491408 [details]
Advanced Search screenshot

Stephen, what's not working?  Here's a screenshot.
(In reply to comment #9)
> Created attachment 491408 [details]
> Advanced Search screenshot
> 
> Stephen, what's not working?  Here's a screenshot.

That's not a datepicker?  http://jqueryui.com/demos/datepicker/ is...
Yeah, that's true.  Probably should have updated the ticket title according to the logic in https://bugzilla.mozilla.org/show_bug.cgi?id=519610#c1 where I decided to use sample text instead of a date picker.
(In reply to comment #11)
> Yeah, that's true.  Probably should have updated the ticket title according to
> the logic in https://bugzilla.mozilla.org/show_bug.cgi?id=519610#c1 where I
> decided to use sample text instead of a date picker.

Sorry, I very clearly have an inability to read bugs carefully; fail.

Verified FIXED; would you be interested in picking up bug 605393?  It's pretty easy to fuzz and get 500 errors (not critical, obviously).

Again, sorry :-(
Cool, no worries.  Thanks Stephen.
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Verified FIXED per comment 12.

/me hand-waves over comment 8 and comment 10 :-)
Status: RESOLVED → VERIFIED
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.