519610 - "Occurs before" search field should use a date picker widget

Status: VERIFIED FIXED

Description

[Jeff Muizelaar [:jrmuizel]]

It's not clear what format the input to "Occurs before" should be in. A date picker widget would help a lot here.

Comment 1

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Created attachment 453261 [details] [diff] [review]
Patch 1 for 519610

Since the time that this ticket was created, we've changed the format of the input field from "MM/DD/YYYY" to "MM/DD/YY HH:MM:SS".

There are 2 options:  We can separate this field into 2 fields, a date field and a time field, and use a date picker for the date field.  Or we can keep these values in the same field and provide a tooltip that shows how to format the data in this field.

I chose the latter because it took up less space on the page and seemed to be the better solution for the UI.

Comment 2

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Thanks Laura.  Committing.  Will be available on stage for testing in 15 minutes at http://crash-stats.stage.mozilla.com/query

==

Sending        webapp-php/application/views/common/query_form.php
Sending        webapp-php/application/views/layout.php
Sending        webapp-php/application/views/query/query.php
Adding         webapp-php/css/jquery.tooltip.css
Adding         webapp-php/js/jquery/plugins/jquery.dimensions.min.js
Adding         webapp-php/js/jquery/plugins/jquery.tooltip.min.js
Sending        webapp-php/js/socorro/query.js
Transmitting file data .......
Committed revision 2176.

Comment 3

[Stephen Donner [:stephend] PTO until ~ Sep. 13]

Verified FIXED on http://crash-stats.stage.mozilla.com/query.

Comment 4

[Laura Thomson :laura]

Merge to 1.7.6

Comment 5

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Committing for 1.7.6.

==

Sending        webapp-php/application/views/layout.php
Sending        webapp-php/application/views/query/query.php
Adding         webapp-php/css/jquery.tooltip.css
Adding         webapp-php/js/jquery/plugins/jquery.dimensions.min.js
Adding         webapp-php/js/jquery/plugins/jquery.tooltip.min.js
Sending        webapp-php/js/socorro/query.js
Transmitting file data ......
Committed revision 2745.

Comment 6

[Stephen Donner [:stephend] PTO until ~ Sep. 13]

I think something's missing, or amiss with the build script?

15:59:00.094: Exception: $(".date-pick").datePicker is not a function Source File: http://crash-stats.stage.mozilla.com/js/socorro/query.js Line: 45, Column: 0 Category: content javascript

Comment 7

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

This should fix it.  Let me know if it does not.  Thanks Stephen!

==

Sending        webapp-php/application/views/query/query.php
Transmitting file data .
Committed revision 2748.

Comment 8

[Stephen Donner [:stephend] PTO until ~ Sep. 13]

Sorry -- still not working, and now, no JS errors.

Comment 9

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Created attachment 491408 [details]
Advanced Search screenshot

Stephen, what's not working?  Here's a screenshot.

Comment 10

[Stephen Donner [:stephend] PTO until ~ Sep. 13]

(In reply to comment #9)
> Created attachment 491408 [details]
> Advanced Search screenshot
> 
> Stephen, what's not working?  Here's a screenshot.

That's not a datepicker?  http://jqueryui.com/demos/datepicker/ is...

Comment 11

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Yeah, that's true.  Probably should have updated the ticket title according to the logic in https://bugzilla.mozilla.org/show_bug.cgi?id=519610#c1 where I decided to use sample text instead of a date picker.

Comment 12

[Stephen Donner [:stephend] PTO until ~ Sep. 13]

(In reply to comment #11)
> Yeah, that's true.  Probably should have updated the ticket title according to
> the logic in https://bugzilla.mozilla.org/show_bug.cgi?id=519610#c1 where I
> decided to use sample text instead of a date picker.

Sorry, I very clearly have an inability to read bugs carefully; fail.

Verified FIXED; would you be interested in picking up bug 605393?  It's pretty easy to fuzz and get 500 errors (not critical, obviously).

Again, sorry :-(

Comment 13

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Cool, no worries.  Thanks Stephen.

Comment 14

[Stephen Donner [:stephend] PTO until ~ Sep. 13]

Verified FIXED per comment 12.

/me hand-waves over comment 8 and comment 10 :-)