Closed
Bug 519610
Opened 16 years ago
Closed 15 years ago
"Occurs before" search field should use a date picker widget
Categories
(Socorro :: General, task)
Socorro
General
Tracking
(Not tracked)
VERIFIED
FIXED
1.7.6
People
(Reporter: jrmuizel, Assigned: ryansnyder)
References
()
Details
Attachments
(2 files)
12.98 KB,
patch
|
laura
:
feedback+
|
Details | Diff | Splinter Review |
140.63 KB,
image/jpeg
|
Details |
It's not clear what format the input to "Occurs before" should be in. A date picker widget would help a lot here.
Updated•15 years ago
|
Assignee: nobody → ryan
Severity: normal → enhancement
Target Milestone: --- → 1.8
Assignee | ||
Comment 1•15 years ago
|
||
Since the time that this ticket was created, we've changed the format of the input field from "MM/DD/YYYY" to "MM/DD/YY HH:MM:SS".
There are 2 options: We can separate this field into 2 fields, a date field and a time field, and use a date picker for the date field. Or we can keep these values in the same field and provide a tooltip that shows how to format the data in this field.
I chose the latter because it took up less space on the page and seemed to be the better solution for the UI.
Attachment #453261 -
Flags: review?(ozten.bugs)
Assignee | ||
Updated•15 years ago
|
Attachment #453261 -
Flags: feedback?(laura)
Updated•15 years ago
|
Attachment #453261 -
Flags: feedback?(laura) → feedback+
Assignee | ||
Comment 2•15 years ago
|
||
Thanks Laura. Committing. Will be available on stage for testing in 15 minutes at http://crash-stats.stage.mozilla.com/query
==
Sending webapp-php/application/views/common/query_form.php
Sending webapp-php/application/views/layout.php
Sending webapp-php/application/views/query/query.php
Adding webapp-php/css/jquery.tooltip.css
Adding webapp-php/js/jquery/plugins/jquery.dimensions.min.js
Adding webapp-php/js/jquery/plugins/jquery.tooltip.min.js
Sending webapp-php/js/socorro/query.js
Transmitting file data .......
Committed revision 2176.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Attachment #453261 -
Flags: review?(ozten.bugs)
Comment 3•15 years ago
|
||
Verified FIXED on http://crash-stats.stage.mozilla.com/query.
Status: RESOLVED → VERIFIED
OS: Mac OS X → All
Hardware: x86 → All
Comment 4•15 years ago
|
||
Merge to 1.7.6
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Target Milestone: 1.8 → 1.7.6
Assignee | ||
Comment 5•15 years ago
|
||
Committing for 1.7.6.
==
Sending webapp-php/application/views/layout.php
Sending webapp-php/application/views/query/query.php
Adding webapp-php/css/jquery.tooltip.css
Adding webapp-php/js/jquery/plugins/jquery.dimensions.min.js
Adding webapp-php/js/jquery/plugins/jquery.tooltip.min.js
Sending webapp-php/js/socorro/query.js
Transmitting file data ......
Committed revision 2745.
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Comment 6•15 years ago
|
||
I think something's missing, or amiss with the build script?
15:59:00.094: Exception: $(".date-pick").datePicker is not a function Source File: http://crash-stats.stage.mozilla.com/js/socorro/query.js Line: 45, Column: 0 Category: content javascript
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 7•15 years ago
|
||
This should fix it. Let me know if it does not. Thanks Stephen!
==
Sending webapp-php/application/views/query/query.php
Transmitting file data .
Committed revision 2748.
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Comment 8•15 years ago
|
||
Sorry -- still not working, and now, no JS errors.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 9•15 years ago
|
||
Stephen, what's not working? Here's a screenshot.
(In reply to comment #9)
> Created attachment 491408 [details]
> Advanced Search screenshot
>
> Stephen, what's not working? Here's a screenshot.
That's not a datepicker? http://jqueryui.com/demos/datepicker/ is...
Assignee | ||
Comment 11•15 years ago
|
||
Yeah, that's true. Probably should have updated the ticket title according to the logic in https://bugzilla.mozilla.org/show_bug.cgi?id=519610#c1 where I decided to use sample text instead of a date picker.
(In reply to comment #11)
> Yeah, that's true. Probably should have updated the ticket title according to
> the logic in https://bugzilla.mozilla.org/show_bug.cgi?id=519610#c1 where I
> decided to use sample text instead of a date picker.
Sorry, I very clearly have an inability to read bugs carefully; fail.
Verified FIXED; would you be interested in picking up bug 605393? It's pretty easy to fuzz and get 500 errors (not critical, obviously).
Again, sorry :-(
Assignee | ||
Comment 13•15 years ago
|
||
Cool, no worries. Thanks Stephen.
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Updated•13 years ago
|
Component: Socorro → General
Product: Webtools → Socorro
You need to log in
before you can comment on or make changes to this bug.
Description
•