519635 - Display glitch in developer hub newsfeed box

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P4)

Description

[Justin Scott [:fligtar]]

Attachment: screenshot

See attached screenshot. The blue link bar is not flush with the bottom.

Comment 1

[Ryan Doherty (:rdoherty)]

Can I get a screenshot of the full newsfeed box?

Comment 2

[Wil Clouser [:clouserw]]

Attachment: screenshot

It's close enough for me that I wouldn't notice, but it is there.

Comment 3

[Justin Scott [:fligtar]]

Attachment: entire box

Screenshot of the entire box.

For bonus points you could do a .blur() on click so my screenshots don't have dotted boxes in them :)

Comment 4

[Ryan Doherty (:rdoherty)]

Attachment: v1

This seems to fix it.

Comment 5

[Ryan Doherty (:rdoherty)]

r52877

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/developers/

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot on Mac

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Sorry, guess I didn't check Mac, or something; still broken there.

Comment 10

[Justin Scott [:fligtar]]

Ryan, can you take a look at Mac?

Comment 11

[Ryan Doherty (:rdoherty)]

Attachment: v2

Rewrote all the layout code for this. Tested in all browsers + rtl. As a bonus I fixed some rtl stuff too. Crossing my fin

This works for the most part in IE 7 & 8 (minor glitch). I'm surprised it works at all in IE.

Comment 12

[Wil Clouser [:clouserw]]

Comment on attachment 407136 [details] [diff] [review]
v2

It looks fine and it'll be better to have more testing sooner rather than just me, so go ahead and land.  Thanks.

Comment 13

[Ryan Doherty (:rdoherty)]

r53741

For QA:
Entire newsfeed box (when logged in) rewritten. Needs to be tested with 1-many add-ons, short/long newsfeed, rtl, browsers, etc.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

This is a pretty scary change to take the day before we fix, but I'll do my best.

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I tested Opera, Safari, Chrome, IE 7/8, Firefox 3, and Firefox 3.5 (blend of Windows and Mac, where appropriate), as well as Farsi (RTL).